Skip to content

Standardized repo files from repo-template#58

Merged
Chris-Wolfgang merged 17 commits intomainfrom
repo
Mar 9, 2026
Merged

Standardized repo files from repo-template#58
Chris-Wolfgang merged 17 commits intomainfrom
repo

Conversation

@Chris-Wolfgang
Copy link
Copy Markdown
Owner

Description

Standardized repo files from repo-template

- Add .editorconfig for strict C# style, async/await, and analyzer rules
- Add .gitattributes for cross-platform line ending consistency
- Expand .gitignore for modern build, IDE, and tool artifacts
- Add .globalconfig for global analyzer and Roslynator settings
- Add BannedSymbols.txt to block sync/obsolete APIs (e.g., Task.Wait, .Result)
- Update Directory.Build.props: latest C# version, analyzers, warnings as errors
- Enforce maintainable, modern, and secure async-first codebase
@Chris-Wolfgang Chris-Wolfgang marked this pull request as ready for review March 9, 2026 02:40
Copilot AI review requested due to automatic review settings March 9, 2026 02:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the repository’s configuration, automation, and housekeeping files with the shared repo-template, adding analyzer/formatting standards, updating CI workflows (PR, release, docs, security), and refreshing GitHub/Dependabot metadata.

Changes:

  • Add repo-wide .NET analyzer configuration (Directory.Build.props + .editorconfig + .globalconfig) including banned API enforcement.
  • Replace/update GitHub Actions workflows for PR validation, releases, docs (DocFX), and security scanning (CodeQL).
  • Standardize repo maintenance files (gitignore/gitattributes, Dependabot, issue templates).

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
Directory.Build.props Enables analyzers/code style and adds analyzer package references + banned API additional file.
BannedSymbols.txt Adds banned API list to enforce async-first and other safety rules.
.globalconfig Adds global analyzer configuration (Roslynator settings).
.gitignore Updates ignore patterns (env, bin, test results, docs outputs, etc.).
.github/workflows/security-scanning.yml Removes prior placeholder security-scanning workflow.
.github/workflows/release.yaml Reworks release pipeline: validation, coverage gate, pack/smoke test, publish, docs trigger, attach artifacts.
.github/workflows/pr.yaml Replaces PR workflow with gated multi-OS pipeline + coverage gate + DevSkim scan.
.github/workflows/docfx.yaml Converts DocFX workflow into reusable workflow with versioned docs deployment + version picker.
.github/workflows/create-labels.yaml Removes label creation workflow.
.github/workflows/codeql.yml Adds CodeQL workflow for security analysis.
.github/workflows/build-all-versions.yaml Adds workflow to build/deploy DocFX for all version tags.
.github/version-picker-template.html Adds HTML template for documentation version picker page.
.github/dependabot.yml Simplifies and groups Dependabot NuGet updates.
.github/ISSUE_TEMPLATE/feature_request.yaml Adds GitHub Issue Form for feature requests.
.github/ISSUE_TEMPLATE/feature_request.md Removes legacy Markdown issue template.
.github/ISSUE_TEMPLATE/bug_report.md Removes legacy Markdown bug report template.
.gitattributes Adds line-ending and binary file handling standardization.
.editorconfig Adds comprehensive editor/analyzer rules and per-folder severity tuning.
Comments suppressed due to low confidence (1)

.github/workflows/release.yaml:33

  • setup-dotnet installs only 5.0–10.0 SDKs here, but the repo’s projects/test projects still target netcoreapp3.1. The test loop later detects TFMs from the project file and will attempt to run dotnet test for netcoreapp3.1, which will fail without installing a 3.1 SDK/targeting pack (or removing/excluding that TFM).
          dotnet-version: |
            5.0.x
            6.0.x
            7.0.x
            8.0.x

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/docfx.yaml
Comment thread BannedSymbols.txt Outdated
Comment thread Directory.Build.props
Comment thread .github/workflows/pr.yaml
Comment thread .github/workflows/codeql.yml
Comment thread .github/workflows/release.yaml
Comment thread .github/workflows/pr.yaml
Comment thread .github/workflows/pr.yaml
Comment thread .github/workflows/pr.yaml Outdated
Chris-Wolfgang and others added 2 commits March 8, 2026 22:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@Chris-Wolfgang I've opened a new pull request, #60, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@Chris-Wolfgang I've opened a new pull request, #61, to work on those changes. Once the pull request is ready, I'll request review from you.

Chris-Wolfgang and others added 4 commits March 8, 2026 23:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 38 out of 40 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread REPO-INSTRUCTIONS.md Outdated
Comment thread README.md
Comment thread README.md
Comment thread CONTRIBUTING.md Outdated
Comment thread .github/workflows/pr.yaml Outdated
Comment thread .github/workflows/pr.yaml Outdated
Comment thread README.md Outdated
Comment thread ETL-Abstractions.sln
Comment thread scripts/Setup-BranchRuleset.ps1
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Comment thread .github/workflows/pr.yaml
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@Chris-Wolfgang I've opened a new pull request, #62, to work on those changes. Once the pull request is ready, I'll request review from you.

Chris-Wolfgang and others added 5 commits March 8, 2026 23:25
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@Chris-Wolfgang I've opened a new pull request, #63, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Chris-Wolfgang Chris-Wolfgang merged commit 2e7c635 into main Mar 9, 2026
3 of 4 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the repo branch March 9, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants