Add .NET 3.1 SDK to release.yaml setup-dotnet steps that run build#61
Merged
Chris-Wolfgang merged 2 commits intorepofrom Mar 9, 2026
Merged
Add .NET 3.1 SDK to release.yaml setup-dotnet steps that run build#61Chris-Wolfgang merged 2 commits intorepofrom
Chris-Wolfgang merged 2 commits intorepofrom
Conversation
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update standardized repo files based on feedback
Add .NET 3.1 SDK to release.yaml setup-dotnet steps that run build
Mar 9, 2026
Chris-Wolfgang
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in release.yaml by adding the .NET 3.1 SDK to the two setup-dotnet steps that precede actual build operations. The project targets netcoreapp3.1 as one of its TFMs, but the release workflow was only installing .NET 5.0–10.0, which caused dotnet restore/dotnet build to fail when attempting to resolve that target.
Changes:
3.1.xadded to thedotnet-versionlist in thevalidate-releasejob'ssetup-dotnetstep (which runsdotnet restoreanddotnet build --configuration Release)3.1.xadded to thedotnet-versionlist in thepack-and-validatejob'ssetup-dotnetstep (which also runsdotnet restoreanddotnet buildbefore packing)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.yamlwas installing only .NET SDKs 5.0–10.0 before runningdotnet restore/dotnet build, butWolfgang.Etl.Abstractions.csprojtargetsnetcoreapp3.1among its TFMs — causing the build to fail without the 3.1 SDK present.Description
Added
3.1.xto thedotnet-versionlist in bothsetup-dotnetsteps that precede build operations:validate-releasejob — runs fulldotnet restore+dotnet build --configuration Releasepack-and-validatejob — runsdotnet restore+dotnet buildbefore packing NuGet packagesThe
publish-nugetjob'ssetup-dotnetstep is unchanged; it only pushes pre-built packages and runs no build steps.Type of change
How Has This Been Tested?
Checklist
Screenshots (if applicable)
N/A
Additional context
Addresses feedback from #58 review. The same pattern (
netcoreapp3.1TFM without a matching SDK) affectspr.yamland other workflows but is out of scope for this PR.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.