Skip to content

Fix pr.yaml: restore 3.1.x SDK to Linux/Windows setup-dotnet, remove duplicates#62

Closed
Copilot wants to merge 13 commits intomainfrom
copilot/sub-pr-58
Closed

Fix pr.yaml: restore 3.1.x SDK to Linux/Windows setup-dotnet, remove duplicates#62
Copilot wants to merge 13 commits intomainfrom
copilot/sub-pr-58

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

Description

3.1.x was dropped from pr.yaml when the simple workflow was replaced with the v3 gated workflow in PR #58. A previous fix attempt added it back to the Windows job but created 3 duplicate entries and left the Linux job without it.

Changes:

  • Linux job (test-linux-core): Add 3.1.x to setup-dotnet — required because the project filter includes netcoreapp* and the repo targets netcoreapp3.1
  • Windows job (test-windows): Collapse 3 duplicate 3.1.x entries to one

macOS job intentionally omits 3.1.x (only runs .NET 6+ targets).

Type of change

  • Bug fix

How Has This Been Tested?

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

Additional context

Addresses review comment on PR #58: #58 (comment)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Chris-Wolfgang and others added 12 commits March 8, 2026 22:33
- Add .editorconfig for strict C# style, async/await, and analyzer rules
- Add .gitattributes for cross-platform line ending consistency
- Expand .gitignore for modern build, IDE, and tool artifacts
- Add .globalconfig for global analyzer and Roslynator settings
- Add BannedSymbols.txt to block sync/obsolete APIs (e.g., Task.Wait, .Result)
- Update Directory.Build.props: latest C# version, analyzers, warnings as errors
- Enforce maintainable, modern, and secure async-first codebase
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
….x in Windows setup-dotnet

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Copilot AI changed the title [WIP] Add feedback response for standardized repo files in PR #58 Fix pr.yaml: restore 3.1.x SDK to Linux/Windows setup-dotnet, remove duplicates Mar 9, 2026
Base automatically changed from repo to main March 9, 2026 21:21
@Chris-Wolfgang Chris-Wolfgang deleted the copilot/sub-pr-58 branch March 12, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants