test: update fast confirmation spec tests to v1.7.0-alpha.13 - #9778
Merged
Conversation
nazarhussain
force-pushed
the
nh/fcr-spec-update-5400
branch
from
August 6, 2026 11:50
22fdba0 to
3923506
Compare
- unskip is_one_confirmed_fails_large_validator_slashed: passes on the slot-start schedule since consensus-specs #5490 reordered the slashing before the tick - assert safe_execution_block_hash (consensus-specs #5449) and the FastConfirmationStore variables in every FCR checks step, exposed via IForkChoice.getFastConfirmationStore() - return ZERO_HASH from getSafeExecutionBlockHash for a genesis anchor: the genesis block body carries a default payload so it is not an execution block per spec; proto array reports the state header hash - skip vectors blocked on upstream generation artifacts (stub deposit signatures, double/skipped on_fast_confirmation runs) and the gloas suite pending the alpha.13 gloas implementation Refs #9690 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Gloas alpha.13 state transition and the gloas-modified get_safe_execution_block_hash landed on unstable (#9393), so the suite passes fully, safe_execution_block_hash assertions included. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nazarhussain
force-pushed
the
nh/fcr-spec-update-5400
branch
from
August 7, 2026 16:19
3923506 to
a3344bb
Compare
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nazarhussain
marked this pull request as ready for review
August 7, 2026 17:08
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9778 +/- ##
=========================================
Coverage 52.60% 52.60%
=========================================
Files 848 848
Lines 60024 60024
Branches 4421 4421
=========================================
Hits 31575 31575
Misses 28390 28390
Partials 59 59 🚀 New features to boost your workflow:
|
wemeetagain
approved these changes
Aug 10, 2026
matthewkeil
approved these changes
Aug 10, 2026
1 task
wemeetagain
pushed a commit
that referenced
this pull request
Aug 12, 2026
**Motivation** #9778 added `IForkChoice.getFastConfirmationStore()` for the spec-test runner; this adds its production consumer by exposing the spec `FastConfirmationStore` variables for debugging fast confirmation on live nodes. **Description** - Add `CheckpointHex` type to lodestar routes and reuse it for existing checkpoint fields - Extend `GET /eth/v1/lodestar/fast_confirmation` with `previousEpochObservedJustifiedCheckpoint`, `currentEpochObservedJustifiedCheckpoint`, `previousEpochGreatestUnrealizedCheckpoint`, `previousSlotHead`, `currentSlotHead` - Populate them from `forkChoice.getFastConfirmationStore()`; shared `toCheckpointHex()` helper in api impl utils Verified: check-types, biome, api + beacon-node unit tests pass; smoke-tested against a live mainnet node with `--chain.fastConfirmation`. Refs: - #9690 - #9778 **AI Assistance Disclosure** - [x] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. Implemented and verified with Claude Code (Claude Fable 5). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update spec tests to v1.7.0-alpha.13 FCR fixes proposed from #9690 (consensus-specs#5489, consensus-specs#5490) and complete the missing FCR assertions.
Description
is_one_confirmed_fails_large_validator_slashed, fixed upstream by consensus-specs#5490fast_confirmationsuite — gloas alpha.13 state transition andget_safe_execution_block_hashlanded via feat: report parent_block_hash for safe/finalized post-Gloas #9393safe_execution_block_hash(consensus-specs#5449) and theFastConfirmationStorevariables, exposed viaIForkChoice.getFastConfirmationStore()(debug API endpoint in a follow-up PR)fast_confirmation(minimal): 1416 passed / 20 skipped / 0 failed. Full spec suites green: minimal 70,899 passed, mainnet 13,586 passed, 0 failures.Refs #9690
AI Assistance Disclosure
Implemented and verified with AI assistance (Claude Code); all changes reviewed and tests executed locally.
🤖 Generated with Claude Code