feat: add ThreadBoundaryError - #5499
Merged
wemeetagain merged 3 commits intoMay 17, 2023
Merged
Conversation
twoeths
marked this pull request as ready for review
May 17, 2023 05:37
wemeetagain
added a commit
that referenced
this pull request
May 17, 2023
* Implement libp2p network thread * Temp enable worker * Fix worker path * Make discv5 options serializable * Move reqResp bridge events to separate EventEmitter * Wire gossip subscribe events * Wire events to worker * Send clonable data only * Fix test types * Represent PeerId in main thread as string * Fix unit tests * Close network core * Ensure network worker data is safe to serialized to worker * fix: NetworkEvent.gossipMessageValidationResult should be from main to worker * fix: remove my test file * small cleanups * more simplification * fix: network e2e tests * Fix gossipsub e2e test * feat: add ThreadBoundaryError (#5499) * feat: add ThreadBoundaryError * Remove ClonableLodestarError * Fix unit test --------- Co-authored-by: Cayman <caymannava@gmail.com> --------- Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com> Co-authored-by: tuyennhv <tuyen@chainsafe.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ThreadBoundaryErrorthat can be passed through thread boundariestoObject()methodobjectas null. They will be deserialized into the generic Error object if passing through thread boundariesFor errors that we want to pass through thread boundaries, they need to
ClonableLodestarErrorclass which includes class name there intoObjectmethodfromObjectmethodRequestErrorandResponseErrorneed thisFor other errors (don't see the need for now) it'll be deserialized into the generic Error object if we pass them through thread boundaries