Fix duplicate FCR run in stale GU test - #5499
Merged
Merged
Conversation
4 tasks
1 task
matthewkeil
pushed a commit
to ChainSafe/lodestar
that referenced
this pull request
Aug 10, 2026
**Motivation** Update spec tests to v1.7.0-alpha.13 FCR fixes proposed from #9690 ([consensus-specs#5489](ethereum/consensus-specs#5489), [consensus-specs#5490](ethereum/consensus-specs#5490)) and complete the missing FCR assertions. **Description** - Unskip `is_one_confirmed_fails_large_validator_slashed`, fixed upstream by [consensus-specs#5490](ethereum/consensus-specs#5490) - Enable the gloas `fast_confirmation` suite — gloas alpha.13 state transition and `get_safe_execution_block_hash` landed via #9393 - Assert `safe_execution_block_hash` ([consensus-specs#5449](ethereum/consensus-specs#5449)) and the `FastConfirmationStore` variables, exposed via `IForkChoice.getFastConfirmationStore()` (debug API endpoint in a follow-up PR) - Skip vectors blocked on upstream vector artifacts, documented inline; the schedule-related ones are already fixed upstream ([consensus-specs#5498](ethereum/consensus-specs#5498), [consensus-specs#5499](ethereum/consensus-specs#5499)) and unskip on the next spec-tests release `fast_confirmation` (minimal): 1416 passed / 20 skipped / 0 failed. Full spec suites green: minimal 70,899 passed, mainnet 13,586 passed, 0 failures. Refs #9690 **AI Assistance Disclosure** - [x] I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. Implemented and verified with AI assistance (Claude Code); all changes reviewed and tests executed locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share similar problem (FCR should run once per slot) with #5498, but this PR actually deduplicates FCR run unlike #5498.
test_fcr_no_restart_if_head_gu_is_staleThis test runs FCR twice when slot number is 24. Line 459-463 advances the store and updates FCR variables until slot 24 (
3 * S). After that, the store never advances, but at line 483 it runs FCR update again which makesprevious_slot_head == current_slot_headbecause:which is not a state we want:
Related to #5400 as this test was added there.