feat: data_column_sidecar sse event support #7953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
changed the title
wemeetagain
reviewed
Jun 11, 2025
| if (emitter.listenerCount(routes.events.EventType.dataColumnSidecar) === 0) return; | ||
|
|
||
| // TODO: Ideally it would be checked with ForkSeq > fulu but it's not returning right type | ||
| if (blockInput.blockData.fork !== ForkName.fulu) return; |
Member
There was a problem hiding this comment.
this can be something like if (isForkPreFulu(...)) return;
then the todo can be removed
Member
There was a problem hiding this comment.
if (!isForkPostFulu(blockInput.blockData.fork)) return; doesn't seem to infer the type correctly but strictly checking for fulu is really error prone and will break in the next fork
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## peerDAS #7953 +/- ##
===========================================
- Coverage 54.36% 54.34% -0.02%
===========================================
Files 843 842 -1
Lines 62137 62118 -19
Branches 4680 4669 -11
===========================================
- Hits 33779 33760 -19
Misses 28285 28285
Partials 73 73 🚀 New features to boost your workflow:
|
nflaig
reviewed
Jun 11, 2025
Member
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
it seems like we emit multiple events if we receive data column sidecars through gossip
wemeetagain
approved these changes
Jun 12, 2025
wemeetagain
pushed a commit
that referenced
this pull request
Jun 23, 2025
) **Motivation** Right now we only emit `blob_sidecar` event during block import when we have received all blobs but this is not ideal as the event is mostly used to gather timing information of when blobs are received by nodes in the network. We should emit the event as soon as possible similar to #7953. **Description** Emit `blob_sidecar` event as soon as we receive `BlobSidecar` - through `publishBlock` api if we are proposer - on `blob_sidecar` gossip topic from the network - from engine api via `engine_getBlobsV1` method - from req/resp via `blob_sidecars_by_root` method
Member
|
🎉 This PR is included in v1.34.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support SSE Events for DataColumn
Description
Add SSE supports for DataColumns.
ethereum/beacon-APIs#535
Steps to test or reproduce
Run all tests