fix: emit blob_sidecar event as soon as we receive BlobSidecars
#7967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
changed the title
blob_sidecar event as soon as we receive BlobSidecars
nflaig
commented
Jun 13, 2025
| await sleep(msToBlockSlot); | ||
| } | ||
|
|
||
| chain.emitter.emit(routes.events.EventType.blockGossip, {slot, block: blockRoot}); |
Member
Author
There was a problem hiding this comment.
moved event down to emit it after we publish to the network
nflaig
commented
Jun 13, 2025
| ]; | ||
| await promiseAllMaybeAsync(publishPromises); | ||
|
|
||
| if (chain.emitter.listenerCount(routes.events.EventType.blockGossip)) { |
Member
Author
There was a problem hiding this comment.
we should probably add this check to a bunch more events, I don't see why we would emit them if there is no listener
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7967 +/- ##
============================================
- Coverage 55.74% 55.71% -0.04%
============================================
Files 833 833
Lines 59383 59418 +35
Branches 4582 4583 +1
============================================
- Hits 33105 33104 -1
- Misses 26211 26247 +36
Partials 67 67 🚀 New features to boost your workflow:
|
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nazarhussain
approved these changes
Jun 19, 2025
wemeetagain
approved these changes
Jun 23, 2025
This was referenced Jun 23, 2025
Member
|
🎉 This PR is included in v1.32.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we only emit
blob_sidecarevent during block import when we have received all blobs but this is not ideal as the event is mostly used to gather timing information of when blobs are received by nodes in the network. We should emit the event as soon as possible similar to #7953.Description
Emit
blob_sidecarevent as soon as we receiveBlobSidecarpublishBlockapi if we are proposerblob_sidecargossip topic from the networkengine_getBlobsV1methodblob_sidecars_by_rootmethod