Add data_column_sidecar event to eventstream API #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the eventstream API to support data_column_sidecar events for PeerDAS (EIP-7594) data availability sampling. The event is emitted when the node receives a DataColumnSidecar that passes all gossip validations.
3 tasks
etan-status
reviewed
Jun 11, 2025
apis/eventstream/index.yaml
Outdated
| description: The node has received a DataColumnSidecar (from P2P or API) that passes all gossip validations on the data_column_sidecar_{subnet_id} topic | ||
| value: | | ||
| event: data_column_sidecar | ||
| data: {"block_root": "0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2", "index": "1", "slot": "1", "kzg_commitments": ["0x1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505cc411d61252fb6cb3fa0017b679f8bb2305b26a285fa2737f175668d0dff91cc1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505"]} |
There was a problem hiding this comment.
the one for blobsidecar has versioned_hash. is a matching versioned_hashes field no longer needed here?
There was a problem hiding this comment.
@etan-status flattening the versioned hashes to a flat byte array and 0xHex-ing it can take a while, per column, per notification, i'd suggest it would be nice if we can skip this field or something, if there's not much use case
moreover i think we'd be streaming the same set of versioned hashes for every data column no? can someone confirm? cc @nalepae
|
Prysm implementation: OffchainLabs/prysm#15387 |
nalepae
approved these changes
Jun 11, 2025
tersec
approved these changes
Jun 11, 2025
dapplion
approved these changes
Jun 11, 2025
nflaig
approved these changes
Jun 11, 2025
mergify bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Jun 11, 2025
N/A Implement events for data column sidecar ethereum/beacon-APIs#535
This was referenced Jun 11, 2025
nazarhussain
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Jun 13, 2025
**Motivation** Support SSE Events for DataColumn **Description** Add SSE supports for DataColumns. ethereum/beacon-APIs#535 **Steps to test or reproduce** Run all tests --------- Co-authored-by: Nico Flaig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the eventstream API to support data_column_sidecar events for PeerDAS (EIP-7594) data availability sampling. The event is emitted when the node receives a DataColumnSidecar that passes all gossip validations.