Skip to content

fix(ci): disable Linux aarch64 wheel build temporarily#1503

Merged
douenergy merged 1 commit intoCanner:mainfrom
goldmedal:fix/disable-aarch64-wheel
Apr 1, 2026
Merged

fix(ci): disable Linux aarch64 wheel build temporarily#1503
douenergy merged 1 commit intoCanner:mainfrom
goldmedal:fix/disable-aarch64-wheel

Conversation

@goldmedal
Copy link
Copy Markdown
Contributor

@goldmedal goldmedal commented Apr 1, 2026

Summary

  • Comment out Linux aarch64 from the wheel build matrix
  • Simplify manylinux back to auto (no per-matrix override needed)
  • Document supported platforms in README

Remaining platforms: Linux x86_64, macOS x86_64/arm64, Windows x86_64.

Root Cause

The ring crate 0.17+ cross-compilation for aarch64 fails due to missing __ARM_ARCH in the manylinux GCC toolchain. Neither manylinux_2_28 nor native ARM runners resolved the issue within the maturin-action Docker build.

Ref: PyO3/maturin-action#222

Test plan

  • Trigger pypi-publish.yml workflow — all 4 remaining builds should pass

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated installation guide to clarify pre-built wheel availability by platform: Linux x86_64, macOS x86_64/ARM64, and Windows x86_64. Linux ARM64 wheels are not available; users on that platform will need to build from source with a Rust toolchain.

The ring crate 0.17+ fails to cross-compile for aarch64 due to
missing __ARM_ARCH in the manylinux GCC toolchain. Disable this
target for now; the remaining 4 platforms cover most users.

Also document supported platforms in README.

Ref: PyO3/maturin-action#222

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation python Pull requests that update Python code ci labels Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1882f71a-33c0-4727-97db-8b8bd62bfb6f

📥 Commits

Reviewing files that changed from the base of the PR and between dfdff01 and 0230bb0.

📒 Files selected for processing (2)
  • .github/workflows/pypi-publish.yml
  • wren-core-py/README.md

📝 Walkthrough

Walkthrough

The PyPI publishing workflow removes the Linux aarch64 wheel build job from the build matrix and changes the manylinux configuration from conditional to constant value. Documentation is updated to clarify which pre-built wheels are available by platform and note that Linux ARM64 requires building from source.

Changes

Cohort / File(s) Summary
CI/Workflow Configuration
.github/workflows/pypi-publish.yml
Removes Linux aarch64 job from wheel build matrix; changes manylinux configuration from conditional expression (${{ matrix.manylinux || 'auto' }}) to constant value (manylinux: auto).
Documentation
wren-core-py/README.md
Adds clarification about pre-built wheel availability by platform (Linux x86_64, macOS x86_64/ARM64, Windows x86_64) and notes that Linux ARM64 wheels are unavailable, requiring source build with Rust toolchain.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

ci, python, documentation

Suggested reviewers

  • douenergy

Poem

🐰 A hop, a skip, the aarch64 departs,
One wheel left behind on the build matrix chart.
"Docs!" cries the rabbit with glee,
"Now all know which wheels they can see!" 🛞

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@douenergy douenergy merged commit 442feab into Canner:main Apr 1, 2026
10 of 11 checks passed
@goldmedal goldmedal deleted the fix/disable-aarch64-wheel branch April 1, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci documentation Improvements or additions to documentation python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants