fix(ci): disable Linux aarch64 wheel build temporarily#1503
fix(ci): disable Linux aarch64 wheel build temporarily#1503douenergy merged 1 commit intoCanner:mainfrom
Conversation
The ring crate 0.17+ fails to cross-compile for aarch64 due to missing __ARM_ARCH in the manylinux GCC toolchain. Disable this target for now; the remaining 4 platforms cover most users. Also document supported platforms in README. Ref: PyO3/maturin-action#222 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PyPI publishing workflow removes the Linux aarch64 wheel build job from the build matrix and changes the manylinux configuration from conditional to constant value. Documentation is updated to clarify which pre-built wheels are available by platform and note that Linux ARM64 requires building from source. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
auto(no per-matrix override needed)Remaining platforms: Linux x86_64, macOS x86_64/arm64, Windows x86_64.
Root Cause
The
ringcrate 0.17+ cross-compilation for aarch64 fails due to missing__ARM_ARCHin the manylinux GCC toolchain. Neithermanylinux_2_28nor native ARM runners resolved the issue within the maturin-action Docker build.Ref: PyO3/maturin-action#222
Test plan
pypi-publish.ymlworkflow — all 4 remaining builds should pass🤖 Generated with Claude Code
Summary by CodeRabbit