fix(ci): use native ARM64 runner for Linux aarch64 wheel build#1501
fix(ci): use native ARM64 runner for Linux aarch64 wheel build#1501douenergy merged 1 commit intoCanner:mainfrom
Conversation
Cross-compiling ring crate on x86_64 for aarch64 fails because the GCC cross-compiler doesn't define __ARM_ARCH. Switch to ubuntu-24.04-arm native runner to avoid cross-compilation entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PyPI publishing GitHub Actions workflow was updated to use a native ARM64 runner ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ubuntu-latest(x86_64) to nativeubuntu-24.04-armrunnerringcrate build failure:#error "ARM assembler must define __ARM_ARCH"when cross-compiling withaarch64-unknown-linux-gnu-gccRoot Cause
The
ringcrate's assembly files require__ARM_ARCHto be defined by the compiler. When cross-compiling on x86_64 with the GCC cross-compiler, this macro is not set, causing the build to fail. Using a native ARM64 runner eliminates cross-compilation entirely.Ref: https://github.com/Canner/wren-engine/actions/runs/23836078522/job/69480140572
Test plan
pypi-publish.ymlworkflow and verify all 5 wheel builds pass🤖 Generated with Claude Code
Summary by CodeRabbit