fix(ci): fix Linux aarch64 wheel build for ring crate compatibility#1502
fix(ci): fix Linux aarch64 wheel build for ring crate compatibility#1502douenergy merged 1 commit intoCanner:mainfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdjusted the PyPI publish workflow to set Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use ubuntu-24.04-arm runner with manylinux_2_28 for the aarch64 wheel. The ring crate 0.17+ needs a newer GCC that defines __ARM_ARCH for ARM assembly. The default manylinux (auto) uses an older toolchain that lacks this macro. Ref: PyO3/maturin-action#222 Ref: briansmith/ring#1728 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
665c504 to
108143f
Compare
Summary
ubuntu-24.04-armnative ARM runner for faster buildsmanylinux_2_28instead ofmanylinux: autofor the aarch64 targetringcrate 0.17+ build failure:#error "ARM assembler must define __ARM_ARCH"Root Cause
The default
manylinux: autopulls a manylinux image with an older GCC cross-compiler that doesn't define__ARM_ARCHfor ARM assembly.manylinux_2_28has a newer GCC that supports this.Ref: PyO3/maturin-action#222
Ref: briansmith/ring#1728
Test plan
pypi-publish.ymlworkflow and verify aarch64 wheel builds🤖 Generated with Claude Code
Summary by CodeRabbit