Merged
Conversation
…troller servers (#1924) * adding CLI test * adding tests for more lines to map_server * fix last test * adding out of bounds and higher bounds checks * adding planner tests for plugins working * add cleanup * working * ping * adding more testing and debug info messages
to simplify retest-until-pass
to reduce line noise
as nav2_system_tests still dominates total test time
Cleanup CircleCI config
* bump to 0.4.2 * removing nav2_bringup from binaries
* Use colcon to check for build failure instead of canary file * Simplify if case for shell * Move extra dockerfiles to docker related folder * Update Dockerfile location * Stage refactor * Use build kit * Update underlay and overlay build * Dockerfile tweek * Rename underlay .repos file * Remove uneeded key * Clone matching distro branch by default * Add optional directive to RUN colcon test * Add comments * Skip the use of symlinks * Roll back to nightly image with all rmws now that connext is fixed * Add slam_toolbox to skipped rosdep keys * Set DEBIAN_FRONTEND env to noninteractive * Update to tag foxy * Updated to latest codecov orb
To fix cpplint
The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from #1857
…tion run-time component (#1953) * removing rviz plugins from test coverage since its not a production run-time component * Update code_coverage_report.bash
* Remove unused achor * Trigger dockerhub build via cron job * Rename workflow * Change timezone trigger dockerhub build 12 am pst test nightly job 6am pst * Clean up dockerhub job refrences * Add missing executors for python_exec * Remove unused devel folder
… footprint (#1952) Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
* remove path_updated blackboard variable to check if the path is updated Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * remove path_udpated from tests Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * make bt_action_node logic clear and fix test failures Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * Revert "make bt_action_node logic clear and fix test failures" This reverts commit bb29d80. Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
…ta_samples (#1619) * Fix tests declaring parameters real nodes don't Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Fix loadParameterWithDeprecation not getting initial parameter values Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Create sim_time variable before using it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Line length < 100 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Add missing { Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Linter fixes Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * sim_granularity -> time_granularity Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Linter fix Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
* Fix memory leak in nav2_recoveries * Fix recovery server memory leak (better interface) * Fix costmap2d memory leak * Fix nav2_navfn_planner memory leak * Fix planner server and navfn planner memory leak * Make all rclcpp::Node::SharedPtr argument passing const * Fix controller server and DWB plugins memory leak * Minor fixes * Fix formatting errors * Change all plugin interfaces to use weak_ptr intead of shared_ptr to parent rclcpp::Node * Convert all SharedPtr to WeakPtr * Check shared_ptr after lock and before dereferencing
* Add kinematic parameters tests. * Solve uncrustify error.
* changing gazebo base to my fork for testing * adding buffer header per TF2 API changes * moving header to header
* adding some more tests to smac_planner * addtl smac tests * remove unused functions
…tor (#2032) * Added a test with controller_frequency of 0. The controller should get a default frequency of 20. * Add kinematic parameters test (#2031) * Add kinematic parameters tests. * Solve uncrustify error. * [WIP fixing CI] changing gazebo base to my fork for testing (#2034) * changing gazebo base to my fork for testing * adding buffer header per TF2 API changes * moving header to header * Adding additional SmacPlanner tests (#2036) * adding some more tests to smac_planner * addtl smac tests * remove unused functions * adding additional constants and smoothers tests (#2038) * Added tests for different controller frequencies. * Added a test with controller_frequency of 0. The controller should get a default frequency of 20. * Added tests for different controller frequencies. * Solve uncrustify issue. Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* Add run-time system test for keepout filter * Add keepout_filter specific logic * Fix review items * Move goal to be on the straight line by plan without keepout
* Fix flaky tests Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Fix shutdown in waypoint follower test Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
* adding input at waypoint executor * exporting depedency * fixing review suggestions * make input topic a parameter * working input executor * adding docs to params md
…2041) * nav2_way_point_follower; introduce photo at waypoint arrivals plugin Signed-off-by: jediofgever <fetulahatas1@gmail.com> * resolve cmake lint errors Signed-off-by: jediofgever <fetulahatas1@gmail.com> * resolve requested chages of first review Signed-off-by: jediofgever <fetulahatas1@gmail.com> * minor corrections on photo_at_waypoint header * resolve requested changes of second review Signed-off-by: jediofgever <fetulahatas1@gmail.com> * update default save_dir Signed-off-by: jediofgever <fetulahatas1@gmail.com> * move directory checking code to initialize()
* update to use on my fork to test changes to bondcpp * using chrono literals in lifecycle manager * nav2_rviz_plugins using chrono literals for API change * using chrono literals in costmap_2d package from API change * using chrono literals in observation buffer * chrono literals for tests costmap * chrono literal API changes * changing API * changing API * API changes * API change * API change * API change * API change test * API change test * remove * api updates * update test values
* nav2_way_point_follower; introduce photo at waypoint arrivals plugin Signed-off-by: jediofgever <fetulahatas1@gmail.com> * resolve cmake lint errors Signed-off-by: jediofgever <fetulahatas1@gmail.com> * resolve requested chages of first review Signed-off-by: jediofgever <fetulahatas1@gmail.com> * minor corrections on photo_at_waypoint header * resolve requested changes of second review Signed-off-by: jediofgever <fetulahatas1@gmail.com> * update default save_dir Signed-off-by: jediofgever <fetulahatas1@gmail.com> * move directory checking code to initialize() * add try catch block to catch possible execeptions while creating a directory for photo at waypoint plugin Signed-off-by: jediofgever <fetulahatas1@gmail.com> * adding logging and disabling * Update nav2_waypoint_follower/plugins/photo_at_waypoint.cpp Co-authored-by: Fetullah Atas <fetulahatas1@gmail.com> * Update photo_at_waypoint.cpp Co-authored-by: jediofgever <fetulahatas1@gmail.com>
#2054) * Support in keepout filter for mask and costmap published in different frames This fixes incorrect keepouts position issue when filter mask and current costmap layer are published in different frames. This might appear (but not restricted only to) when keepout filter is enabled for local costmap with rolling window. * Add transform initialization * Enhance transform failure message
* Abort analytic expansion if crossing through already visited node * Check that we are not creating an infinite loop at the goal node * Mark nodes in analytic expansion as visited for the sake of completeness * Move checking of already visited nodes to final stage of analytic expansion
* Fix shared_ptr cyclic dependencies Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Refactor costmap downsampler and fix test Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Revert costmap downsampler test changes Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
- Add Map Saver resource sharing - Add forgotten reset of save_map_service_ - Remove unnecessary map republisher - Increase save_map_timeout
* adding new logo! * limit dimensions * limit dimensions * limit dimensions
* Fix build on macOS with LLVM/Clang12 * nav2_costmap_2d's observation buffer is now using tf_tolerance. Removed pragmas and os specific logic
…ajjar.1997@gmail.com> (#2093)
* Test setting the parameters. * Added the score tests. * Use variables for parameters and add test for non-default values. * Cleanup. Removed commented out code.
* Setup for obstacle footprint test. * Make std::string arguments const * Added additional tests for obstacle footprint test. * Add todo. * Several code cleanup actions. Renamed the function p to getPoint. Removed commented out code. Fixed the trow->throw typo and explained some tests in comments.
* adding unit testing for alignment util dwb critics * adding twirling tests * renaming test
* Removing eloquent from build status table since its EOL * Update README.md * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points