Skip to content

fix(proxy): add coordination_redis routes to component allowlist - #32805

Merged
yucheng-berri merged 1 commit into
litellm_coordination_redis_configfrom
litellm_fix_coordination_redis_allowlist
Jul 10, 2026
Merged

fix(proxy): add coordination_redis routes to component allowlist#32805
yucheng-berri merged 1 commit into
litellm_coordination_redis_configfrom
litellm_fix_coordination_redis_allowlist

Conversation

@yucheng-berri

Copy link
Copy Markdown
Contributor

Relevant issues

Unblocks PR #32661.

Linear ticket

Resolves LIT-3861

Pre-Submission checklist

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem

Screenshots / Proof of Fix

$ python3 -m pytest tests/test_litellm/proxy/test_component_allowlists.py::test_gateway_plus_backend_covers_full_app -v
PASSED tests/test_litellm/proxy/test_component_allowlists.py::test_gateway_plus_backend_covers_full_app
1 passed in 3.01s

Type

🐛 Bug Fix

Changes

PR #32661 added /coordination_redis/settings and /coordination_redis/settings/test endpoints but did not add them to backend/routes/allowlist.py. The test_gateway_plus_backend_covers_full_app test enforces that every registered route appears in either the gateway or backend allowlist, causing that test to fail with:

AssertionError: 2 route(s) are not exposed on either component.
    /coordination_redis/settings
    /coordination_redis/settings/test

Adding /coordination_redis/ as a prefix entry to the backend allowlist covers both routes and unblocks the CI check

@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds /coordination_redis/ as a prefix entry in BACKEND_PATH_PREFIXES inside backend/routes/allowlist.py, fixing a CI failure caused by two new endpoints (/coordination_redis/settings and /coordination_redis/settings/test) introduced in PR #32661 that were not registered in the allowlist.

  • The single-line addition correctly covers both routes since both begin with /coordination_redis/, satisfying the test_gateway_plus_backend_covers_full_app coverage invariant.
  • The placement is consistent with neighboring settings-style entries (/cache_settings, /router_settings) in the "Models & routing config" section, and the PR includes the passing test output as evidence of the fix.

Confidence Score: 5/5

Safe to merge; the change is a one-line addition to a static allowlist tuple with no runtime logic involved.

The change is a single entry added to a read-only tuple. The affected test passes according to the provided output, the prefix /coordination_redis/ cleanly covers both missing routes, and the placement in the allowlist file is consistent with surrounding entries.

No files require special attention.

Important Files Changed

Filename Overview
backend/routes/allowlist.py Added /coordination_redis/ prefix to BACKEND_PATH_PREFIXES, covering the two routes introduced by PR #32661 (/coordination_redis/settings and /coordination_redis/settings/test)

Reviews (1): Last reviewed commit: "fix(proxy): add coordination_redis route..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yucheng-berri
yucheng-berri merged commit 7170c01 into litellm_coordination_redis_config Jul 10, 2026
97 checks passed
@yucheng-berri
yucheng-berri deleted the litellm_fix_coordination_redis_allowlist branch July 10, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants