Skip to content

fix(proxy): add coordination_redis routes to component allowlist - #32749

Closed
mateo-berri wants to merge 1 commit into
litellm_coordination_redis_configfrom
litellm_fix_coordination_redis_allowlist-0756
Closed

fix(proxy): add coordination_redis routes to component allowlist#32749
mateo-berri wants to merge 1 commit into
litellm_coordination_redis_configfrom
litellm_fix_coordination_redis_allowlist-0756

Conversation

@mateo-berri

Copy link
Copy Markdown
Contributor

Relevant issues

Unblocks PR #32661.

Linear ticket

Resolves LIT-3861

Pre-Submission checklist

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem

Screenshots / Proof of Fix

$ python3 -m pytest tests/test_litellm/proxy/test_component_allowlists.py::test_gateway_plus_backend_covers_full_app -v
PASSED tests/test_litellm/proxy/test_component_allowlists.py::test_gateway_plus_backend_covers_full_app
1 passed in 4.65s

Type

🐛 Bug Fix

Changes

PR #32661 added /coordination_redis/settings and /coordination_redis/settings/test endpoints but did not add them to backend/routes/allowlist.py. The test_gateway_plus_backend_covers_full_app test enforces that every registered route appears in either the gateway or backend allowlist, causing that test to fail with:

AssertionError: 2 route(s) are not exposed on either component.
    /coordination_redis/settings
    /coordination_redis/settings/test

Adding /coordination_redis/ as a prefix entry to the backend allowlist covers both routes and unblocks the CI check.

Open in Web Open in Cursor 

Co-authored-by: Mateo Wang <mateo-berri@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a single missing prefix entry to the backend route allowlist to fix a CI enforcement failure. PR #32661 introduced /coordination_redis/settings and /coordination_redis/settings/test endpoints but omitted them from backend/routes/allowlist.py, causing the test_gateway_plus_backend_covers_full_app test to fail.

  • Adds /coordination_redis/ to BACKEND_PATH_PREFIXES, which covers both new endpoints via prefix matching (startswith).
  • The trailing-slash pattern is consistent with other multi-route prefixes in the file (e.g., /router/, /cache/, /config/) and correctly distinguishes these routes from any hypothetical top-level /coordination_redis exact match.

Confidence Score: 5/5

Safe to merge — one-line addition to an allowlist with a dedicated enforcement test that now passes.

The change is a single-line addition to a static tuple. The affected test explicitly verifies that every registered route appears in either the gateway or backend allowlist, so the fix is self-validating. The new prefix /coordination_redis/ correctly matches both target routes by prefix and is consistent with the style of other entries in the file.

No files require special attention.

Important Files Changed

Filename Overview
backend/routes/allowlist.py Adds /coordination_redis/ prefix to BACKEND_PATH_PREFIXES, correctly covering both /coordination_redis/settings and /coordination_redis/settings/test routes added in PR #32661.

Reviews (1): Last reviewed commit: "fix(proxy): add coordination_redis route..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yucheng-berri

Copy link
Copy Markdown
Contributor

Superseded by #32805, which carries the identical change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants