fix(proxy): add coordination_redis routes to component allowlist - #32749
fix(proxy): add coordination_redis routes to component allowlist#32749mateo-berri wants to merge 1 commit into
Conversation
Co-authored-by: Mateo Wang <mateo-berri@users.noreply.github.com>
|
|
Greptile SummaryThis PR adds a single missing prefix entry to the backend route allowlist to fix a CI enforcement failure. PR #32661 introduced
Confidence Score: 5/5Safe to merge — one-line addition to an allowlist with a dedicated enforcement test that now passes. The change is a single-line addition to a static tuple. The affected test explicitly verifies that every registered route appears in either the gateway or backend allowlist, so the fix is self-validating. The new prefix /coordination_redis/ correctly matches both target routes by prefix and is consistent with the style of other entries in the file. No files require special attention.
|
| Filename | Overview |
|---|---|
| backend/routes/allowlist.py | Adds /coordination_redis/ prefix to BACKEND_PATH_PREFIXES, correctly covering both /coordination_redis/settings and /coordination_redis/settings/test routes added in PR #32661. |
Reviews (1): Last reviewed commit: "fix(proxy): add coordination_redis route..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Superseded by #32805, which carries the identical change |
Relevant issues
Unblocks PR #32661.
Linear ticket
Resolves LIT-3861
Pre-Submission checklist
Screenshots / Proof of Fix
Type
🐛 Bug Fix
Changes
PR #32661 added
/coordination_redis/settingsand/coordination_redis/settings/testendpoints but did not add them tobackend/routes/allowlist.py. Thetest_gateway_plus_backend_covers_full_apptest enforces that every registered route appears in either the gateway or backend allowlist, causing that test to fail with:Adding
/coordination_redis/as a prefix entry to the backend allowlist covers both routes and unblocks the CI check.