Skip to content

fix(proxy): add coordination_redis routes to component allowlist - #32823

Merged
yucheng-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_fix_coordination_redis_allowlist_staging
Jul 10, 2026
Merged

fix(proxy): add coordination_redis routes to component allowlist#32823
yucheng-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_fix_coordination_redis_allowlist_staging

Conversation

@yucheng-berri

@yucheng-berri yucheng-berri commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Relevant issues

Unblocks PR #32661.

Linear ticket

Pre-Submission checklist

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem

Screenshots / Proof of Fix

$ python3 -m pytest tests/test_litellm/proxy/test_component_allowlists.py::test_gateway_plus_backend_covers_full_app -v
PASSED tests/test_litellm/proxy/test_component_allowlists.py::test_gateway_plus_backend_covers_full_app
1 passed in 3.01s

Type

🐛 Bug Fix

Changes

PR #32661 adds /coordination_redis/settings and /coordination_redis/settings/test endpoints but does not add them to backend/routes/allowlist.py. The test_gateway_plus_backend_covers_full_app test enforces that every registered route appears in either the gateway or backend allowlist, causing that test to fail on #32661 with:

AssertionError: 2 route(s) are not exposed on either component.
    /coordination_redis/settings
    /coordination_redis/settings/test

Adding /coordination_redis/ as a prefix entry to the backend allowlist covers both routes. The entry is inert on staging until #32661's routes land (the coverage test only checks registered routes against the allowlist, not the reverse).

@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes a single-line addition to backend/routes/allowlist.py, inserting /coordination_redis/ into BACKEND_PATH_PREFIXES so that the /coordination_redis/settings and /coordination_redis/settings/test routes (introduced in the companion PR #32661) pass the test_gateway_plus_backend_covers_full_app coverage check.

  • The new prefix follows the established trailing-slash convention used by other config-admin routes (e.g., /router/, /cache/) and correctly matches both target paths via startswith.
  • The entry is currently inert on staging — the coverage test only verifies registered routes appear in an allowlist, not the reverse — so there is no runtime risk until feat(proxy): configure the coordination redis independently of the response cache #32661 lands.

Confidence Score: 5/5

A one-line allowlist addition with no runtime effect until the companion PR merges; safe to merge as-is.

The change is a single prefix string added to a static tuple. It correctly covers both target paths, matches the existing trailing-slash pattern used throughout the file, and is verified by the coverage test cited in the PR description. No logic, auth, or data-plane code is touched.

No files require special attention.

Important Files Changed

Filename Overview
backend/routes/allowlist.py Adds /coordination_redis/ prefix to BACKEND_PATH_PREFIXES, enabling the backend component to serve the upcoming /coordination_redis/settings and /coordination_redis/settings/test routes from PR #32661.

Reviews (1): Last reviewed commit: "fix(proxy): add coordination_redis route..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed-hq

codspeed-hq Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_fix_coordination_redis_allowlist_staging (4598059) with litellm_internal_staging (34602ff)

Open in CodSpeed

@yucheng-berri
yucheng-berri merged commit 6d17f9e into litellm_internal_staging Jul 10, 2026
127 checks passed
@yucheng-berri
yucheng-berri deleted the litellm_fix_coordination_redis_allowlist_staging branch July 10, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants