Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype for Search_oM and Search_Engine #7

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jan 8, 2024

NOTE: Depends on

BHoM/BHoM#1586
BHoM/BHoM_Engine#3247

Issues addressed by this PR

Closes #4

Test files

Fuzzy Matching

Changelog

  • Migrated the FuzzyMatching functionality to the Search_Engine;
  • Migrated the FuzzyMatching eNums to the Search_oM;

Additional comments

Just deleting methods that have been migrated, should be enough to review by inspection.

@peterjamesnugent peterjamesnugent self-assigned this Jan 8, 2024
@peterjamesnugent peterjamesnugent added the status:WIP PR in progress and still in draft, not ready for formal review label Jan 8, 2024
@peterjamesnugent peterjamesnugent changed the title Ags toolkit #3 prototyping with fuzzy matching Prototype for Search_oM and Search_Engine Jan 13, 2024
@peterjamesnugent peterjamesnugent added type:feature New capability or enhancement and removed status:WIP PR in progress and still in draft, not ready for formal review labels Jan 17, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Jan 23, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in line with oM and Engine updates which moved files from here to there.

@FraserGreenroyd FraserGreenroyd merged commit ec88880 into develop Jan 26, 2024
2 checks passed
@FraserGreenroyd FraserGreenroyd deleted the AGS_Toolkit-#3-PrototypingWithFuzzyMatching branch January 26, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AGS_Adapter to check if the file is incorrectly formated
2 participants