fix: simplify logic and enable correct recording rule groups for managed prom extension #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged prom extension
bragi92
requested review from
anagg929,
bavneetsingh16 and
deeksha345
as code owners
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
gracewehner
approved these changes
May 29, 2025
bavneetsingh16
approved these changes
May 29, 2025
bavneetsingh16
pushed a commit
that referenced
this pull request
May 29, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
May 30, 2025
…ged prom extension (#7)
bavneetsingh16
added a commit
that referenced
this pull request
May 30, 2025
* add pester tests for k8s-extension * Adding CLI Configuration for DisableInformerCache Flag (#2) This is required for our helm charts where customers can opt to change the caching behaviour during restore. * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * remove test cases specific to fork repo --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]> Co-authored-by: bragi92 <[email protected]>
bavneetsingh16
pushed a commit
that referenced
this pull request
May 30, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
May 30, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 6, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 6, 2025
…ged prom extension (#7)
bavneetsingh16
added a commit
that referenced
this pull request
Aug 19, 2025
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#12) * remove extension specific pester tests --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Long Wan <[email protected]>
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (Azure#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * feat: enable openapi spec from url in api register (Azure#74) * feat: enable openapi spec from url in api register * refactor: set spec definition as link format when link provided * fix: fix style * test: add error handling case for testing invalid spec url * fix: fix test case * fix: use 404 response url * test: update case * test: update test case * refactor: update error logic * test: update test case to setup live test pipeline (Azure#76) * test: update test case to setup live test pipeline (Azure#75) * test: update test case * update * . * . * . * . * . * . * . * . * . * . * . * test: update test case * refactor: enable both identity * fix: bad if else * fix: fix bad parameter * refactor: add example (Azure#77) * refactor: add example * fix: update params * fix: bad api id * refactor: add @filename.json examples (Azure#78) * refactor: add example * fix: update params * fix: bad api id * refactor: add @filename.json examples * refactor: update * refactor: add error handling (Azure#79) * refactor: add error handling * refactor: catch internal error * fix: revert the change * feat: support APIM/APIC sync (Azure#80) * feat: add APIM/APIC sync commands * feat: rename apim to azure-api-management * style: fix code style * fix: sync property names with new API spec * Revert "fix: sync property names with new API spec" This reverts commit 04da67e. --------- Co-authored-by: frankqianms <[email protected]> * feat: resolve feedback and fix examples (Azure#82) * feat: resolve feedback and fix examples * style: fix code style * feat: amazon api gateway sync (Azure#81) * feat: add APIM/APIC sync commands * feat: rename apim to azure-api-management * style: fix code style * fix: sync property names with new API spec * feat: add aws api gateway sync command * Revert "fix: sync property names with new API spec" This reverts commit 04da67e. * refactor: add amazonApiGatewaySource * refactor: refactoring apim sync and amazon sync * refactor: refactor cmd structure to make apim and aws sync seperated * fix: remove log print * chore: generate new cmds * refactor: update version and remove import * feat: add `apic integration create amazon-api-gateway` * fix: style * fix: change query param api-version * revert changes in _delete.py * fix: some neede fixs * fix: add the help sentence * refactor: make params clear * refactor: handle msi-resource-id * refacor: revert flatten of apim resource * fix: use 06-01-preiew currently * fix: style * refactor: arg groups * fix: bad short param name * chore: re-generate * fix: old resource_id name * chore: arg group * chore: naming * fix: fix according to comments * chore: update * fix: style --------- Co-authored-by: Chaoyi Yuan <[email protected]> * feat: add import amazon-api-gateway cmd (Azure#83) * feat: add import amazon-api-gateway cmd * feat: change arg group and update parameter name --------- Co-authored-by: Chaoyi Yuan <[email protected]> * fix: use older version API (Azure#84) * feat: rename command and param names (Azure#85) * feat: rename command and param names * doc: update comments * doc: update sample * test: add test case for sync cmd `apic integration create apim` and `apic integration create aws` (Azure#86) * test: add test case for apim sync * refactor: refactor for apim preparer * refactor: refactoring case and utils, optimize checkers * chore: remove print and add explaination * refactor: rename file * fix: try to fix error determing the version * revert: Remove specific azure-cli and azure-core installations * test: add aws sync testcase (Azure#87) * test: add test case for aws sync command * fix: remove key value * fix: remove pip install * chore: renaming constants * refactor: update the utils and test case * refactor: updated * fix: workaround for urllib3 package (Azure#88) * Revert "fix: workaround for urllib3 package (Azure#88)" (Azure#90) This reverts commit 1d508f4. * build: 1.2.0 beta 1 release * build: remove CI and CD files * doc: improve history * fix: set extention version to be preview * refactor: integration examples and bad example for `apic update` (Azure#91) * refactor: integration examples * fix: apic update example * feat: add api-analysis rules (Azure#89) * feat: analysi rule init * feat: add create cmd * feat: add create and delete api-analysis commands * feat: add import-ruleset and export-ruleset commands * fix: update aaz * fix: registered * fix: examples * fix: fix style * refactor: renaming * refactor: regenerate aaz * fix: fix codes * fix: fix logics * fix: style * fix: rename parameter service name * fix: change api-analysis status to preview * fix: integration list * refactor: modify examples * feat: analysi rule init * feat: add create cmd * feat: add create and delete api-analysis commands * feat: add import-ruleset and export-ruleset commands * fix: update aaz * fix: registered * fix: examples * fix: fix style * refactor: renaming * refactor: regenerate aaz * fix: fix codes * fix: fix logics * fix: style * fix: change api-analysis status to preview * fix: change short name of service name * fix: apic update example * fix: examples and default value * chore: example * fix: bad parameter short names * fix: downgrade api version * fix: set default workspace for list,show,update api-analysis * refactor: integration examples * fix: style * chore: update log * test: add import-aws case and modify region * feat: add import apim and deperacate import-from-apim, add analysis create and list test cases * fix: correctly deprecate import-from-apim * test: add apianalysis test cases * build: bump up to 1.2.0b2 * test: add api-analysis update testcase * build: change log of 1.2.0b2 * chore: unregister the filter * fix: better methods name and remove extra lint disable * refactor: set default analyzer-type in aaz * refactor: remove preview tag for some integration commands and hide the analyzer_type param * chore: update spec for filter param * fix: set default analyzer_type correctly * fix: import apim fix (Azure#92) * add CD * rename * upgrade upload-artifact * fix: fix missing apis param in import apim * fix: regenerate according to new spec * cd: remove cd file * test: update test cases * fix: fix spec version in register command * test: update test cases * test: update recordings * test: live test * fix: fix test cases of api analysis * fix: update recordings * fix: remove comment * fix: merge and align latest version * Update command_patches.py fix linter * fix: remove import cmds & preview tag of integrate cmds * test: remove uneeded test cases * fix: fix linter failures for auto generated params * test: update tests * Update HISTORY.rst * fix: remove extra yml * Update HISTORY.rst * test: update test cases and recordings * fix: fix cases --------- Co-authored-by: Chaoyi Yuan <[email protected]> Co-authored-by: Chaoyi Yuan <[email protected]>
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
bavneetsingh16
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ged prom extension (#7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az k8s-extension create --name azuremonitor-metrics --cluster-name <Arc-cluster-name> --resource-group <Arc-resource-group> --cluster-type connectedClusters --extension-type Microsoft.AzureMonitor.Containers.Metricsaz k8s-extension update --name azuremonitor-metrics --resource-group <Arc-resource-group> --cluster-name <Arc-cluster-name> --cluster-type connectedClustersGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.