-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[k8s-extension] Update extension CLI to v1.6.5 #8814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
…ged prom extension (#7)
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the extension CLI to version v1.6.5. Key changes include:
- Bumping the version in setup.py from 1.6.4 to 1.6.5.
- Enhancing the logic for recording rules in both the delete and create modules.
- Adding support for a new configuration parameter (Disable Informer Cache) in DataProtectionKubernetes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/k8s-extension/setup.py | Version number update to v1.6.5. |
| src/k8s-extension/azext_k8s_extension/partner_extensions/azuremonitormetrics/recordingrules/delete.py | Added an extra deletion call for a UX recording rules group. |
| src/k8s-extension/azext_k8s_extension/partner_extensions/azuremonitormetrics/recordingrules/create.py | Revised logic to iterate over filtered recording rules and conditionally create rule groups. |
| src/k8s-extension/azext_k8s_extension/partner_extensions/DataProtectionKubernetes.py | Introduced a new configuration key for disabling the informer cache. |
| src/k8s-extension/HISTORY.rst | Updated release history with v1.6.5 notes. |
Comments suppressed due to low confidence (1)
src/k8s-extension/azext_k8s_extension/partner_extensions/azuremonitormetrics/recordingrules/delete.py:42
- The naming of the recording rules group contains extra whitespace around the hyphen. Consider using a consistent format, for example 'UXRecordingRulesRuleGroup-{0}', to align with the naming pattern used in other parts of the code.
"UXRecordingRulesRuleGroup - {0}".format(cluster_name)
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here: As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite |
|
|
[Release] Update index.json for extension [ k8s-extension-1.6.5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125780211&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.