Skip to content

Conversation

@mayankagg9722
Copy link

This is required for our helm charts where customers can opt to change the caching behaviour during restore.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Create command:

az k8s-extension create --name azure-aks-backup --extension-type Microsoft.DataProtection.Kubernetes --scope cluster --cluster-name p1a-scaleTest-cluster --resource-group priyansh-p1a --cluster-type managedClusters --release-train stable --configuration-settings blobContainer=extension-aks storageAccountResourceGroup=priyansh-p1a storageAccount=p1ascalesa storageAccountSubscriptionId=a54fc8c4-a7cd-4ae1-b404-b2c317c2e58c disableInformerCache=true cpuRequest=1000m cpuLimit=1200m memoryRequest=300Mi memoryLimit=1800Mi

Update Command

az k8s-extension update --name azure-aks-backup --cluster-name p1a-scaleTest-cluster --resource-group priyansh-p1a --cluster-type managedClusters --release-train stable --configuration-settings blobContainer=extension-aks storageAccountResourceGroup=priyansh-p1a storageAccount=p1ascalesa storageAccountSubscriptionId=a54fc8c4-a7cd-4ae1-b404-b2c317c2e58c disableInformerCache=true cpuRequest=1000m cpuLimit=1200m memoryRequest=300Mi memoryLimit=1800Mi

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

This is required for our helm charts where customers can opt to change the caching behaviour during restore.
@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@mayankagg9722 mayankagg9722 merged commit 4d8750e into main May 15, 2025
8 of 12 checks passed
@bavneetsingh16 bavneetsingh16 deleted the users/mayaggar/aksbackup branch May 15, 2025 16:31
bavneetsingh16 pushed a commit that referenced this pull request May 23, 2025
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
bavneetsingh16 pushed a commit that referenced this pull request May 23, 2025
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
bavneetsingh16 pushed a commit that referenced this pull request May 29, 2025
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
bavneetsingh16 added a commit that referenced this pull request May 30, 2025
* add pester tests for k8s-extension

* Adding CLI Configuration for DisableInformerCache Flag (#2)

This is required for our helm charts where customers can opt to change the caching behaviour during restore.

* fix testcases for nodepool image issues (#5)

* update readme and version release notes (#6)

* fix: simplify logic and enable correct recording rule groups for managed prom extension (#7)

* remove test cases specific to fork repo

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Mayank Aggarwal <[email protected]>
Co-authored-by: bragi92 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants