-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @useSystemTextJsonConverter
decorator for csharp
#1336
Conversation
All changed packages have been documented.
Show changes
|
516c321
to
1fd1583
Compare
You can try these changes here
|
yeah made the same comment on the old PR #1230 (comment) My opinion is that either
|
This decorator does not fit the usage for Java, please check https://teams.microsoft.com/l/message/19:meeting_MGQ4YTVhYTYtZWU1OC00NzI4LWEzYzktMjgzYzg3OTBkY2Q5@thread.v2/1723169831963?context=%7B%22contextType%22%3A%22chat%22%7D I raised the concern of csharp specific decorator, but we decided to go in root namespace and default to all scopes during the previous discussion, please check https://teams.microsoft.com/l/message/19:meeting_MGQ4YTVhYTYtZWU1OC00NzI4LWEzYzktMjgzYzg3OTBkY2Q5@thread.v2/1723177908738?context=%7B%22contextType%22%3A%22chat%22%7D |
Resolves #1229
This change has already been approved in #1230