Add @useSystemTextJsonConverter decorator for csharp
#1230
Conversation
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
live1206
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
live1206
changed the title
@hasJSONConverter decorator@hasJSONConverter decorator for csharp
|
Given the timeline: Azure/autorest.csharp#3469 (comment), we would like to get this out in the next release. |
packages/typespec-client-generator-core/test/types/general-decorators-list.test.ts
Show resolved
Hide resolved
live1206
changed the title
@hasJSONConverter decorator for csharp@hasJsonConverter decorator for csharp
| - "@azure-tools/typespec-client-generator-core" | ||
| --- | ||
|
|
||
| Add `@hasJsonConverter` for csharp only to indicate if JSON converter is needed |
There was a problem hiding this comment.
lets rename to @useSystemTextJsonConverter to make it more explicit what this is used for.
There was a problem hiding this comment.
I'll say it feels quite weird having this at the root of Tcgc namespace with this name that is very csharp specific
There was a problem hiding this comment.
I think this is indeed csharp specific only decorator.
@timotheeguerin Are you implying we should keep it within csharp sub-namespace if we ensure it will not be used for other languages?
There was a problem hiding this comment.
Yeah just feels like this is not super compatible with the new approach of using a shared name and scope.
But if you feel like it's best then I'm not blocking or anything
There was a problem hiding this comment.
We have decided that language-specific decorators will go in the main namespace because of grow-up, but they will have to specify the scope, and we have an issue to have linter warnings if a decorator is applied to emitters that won't do anything with it.
My question with this PR is more: I thought we had decided that there was a use case for Java here too, and that there was going to be a redesign of this decorator (most likely just a rename), that would make it compatible with Java's scenario as well
live1206
changed the title
@hasJsonConverter decorator for csharp@useSystemTextJsonConverter decorator for csharp
live1206
force-pushed
the
json-converter
branch
from
516c321
to
1fd1583
Compare
|
merge to august release branch instead in #1336 |
#1229