Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a @useSystemTextJsonConverter decorator for csharp only #1229

Closed
4 tasks done
live1206 opened this issue Jul 24, 2024 · 0 comments
Closed
4 tasks done

Add a @useSystemTextJsonConverter decorator for csharp only #1229

live1206 opened this issue Jul 24, 2024 · 0 comments
Assignees
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@live1206
Copy link
Member

live1206 commented Jul 24, 2024

Clear and concise description of the problem

In Azure/autorest.csharp#3469, we need to flag if a model needs specific handling of JSON converter.
So that, we would like to add a csharp only decorator @hasJSONConverter in TCGC, but with in a different namespace Azure.ClientGenerator.Core.CSharp

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@live1206 live1206 self-assigned this Jul 24, 2024
@timotheeguerin timotheeguerin added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Jul 24, 2024
@timotheeguerin timotheeguerin changed the title [TCGC] Add a @hasJSONConverter decorator for csharp only Add a @hasJSONConverter decorator for csharp only Jul 24, 2024
@iscai-msft iscai-msft added this to the [2024] September milestone Aug 7, 2024
@live1206 live1206 changed the title Add a @hasJSONConverter decorator for csharp only Add a @useSystemTextJsonConverter decorator for csharp only Aug 9, 2024
tadelesh pushed a commit that referenced this issue Aug 9, 2024
Resolves #1229
This change has already been approved in
#1230
@tadelesh tadelesh closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

4 participants