tsp, bump cadl-ranch #2820
Merged
tsp, bump cadl-ranch #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
changed the title
Comment on lines
308
to
309
| // // make the logic same as TCGC, which takes the service default of host as client default | ||
| // clientDefaultValue: getDefaultValue(it.defaultValue), |
There was a problem hiding this comment.
currently disable this line, not sure the status of corresponding TCGC behavior Azure/typespec-azure#1030
| @@ -61,7 +61,6 @@ | |||
| "lodash": "~4.17.21" | |||
| }, | |||
| "devDependencies": { | |||
| "@azure-tools/typespec-autorest": "0.43.0", | |||
There was a problem hiding this comment.
It is removed from @azure-tools/typespec-azure-resource-manager
typespec-tests/Generate.ps1
Outdated
| $tspOptions += " --option ""@azure-tools/typespec-java.group-etag-headers=false""" | ||
| } elseif ($tspFile -match "azure[\\/]arm[\\/]") { | ||
| # for mgmt, do not generate tests due to random mock values | ||
| $tspOptions += " --option ""@azure-tools/typespec-java.generate-tests=false""" |
There was a problem hiding this comment.
disable mock test
There was a problem hiding this comment.
struggling on the regex, going to take a while
XiaofeiCao
approved these changes
Jun 18, 2024
weidongxu-microsoft
requested review from
haolingdong-msft and
srnagar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.