Skip to content

Add setting the registry in the npmrc#14353

Merged
chidozieononiwu merged 2 commits intoAzure:mainfrom
chidozieononiwu:AllowNpmJSAccess
Mar 5, 2026
Merged

Add setting the registry in the npmrc#14353
chidozieononiwu merged 2 commits intoAzure:mainfrom
chidozieononiwu:AllowNpmJSAccess

Conversation

@chidozieononiwu
Copy link
Member

Packages impacted by this PR

  • All

Issues associated with this PR

Azure/azure-sdk-for-js#37076

Describe the problem that is addressed by this PR

  • When releasing to npmjs reset the registry in npmrc

Copilot AI review requested due to automatic review settings March 5, 2026 00:38
@chidozieononiwu chidozieononiwu requested a review from a team as a code owner March 5, 2026 00:38
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the shared npm publish pipeline to explicitly reset the project npm registry back to https://registry.npmjs.org/ during npmjs releases, addressing cases where a repo .npmrc might point at a different registry.

Changes:

  • Added a new pipeline step template to set (and log) the project npm registry via npm config.
  • Replaced the inline “delete repo .npmrc” step in the npm publish job with the new reset-registry template.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/common/pipelines/templates/steps/reset-npmrc.yml New step template that sets the project npm registry to the provided value.
eng/common/pipelines/templates/jobs/npm-publish.yml Switches npmjs.org publish path to use the new reset-registry template instead of deleting .npmrc.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

chidozieononiwu added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 5, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#14353 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
chidozieononiwu added a commit to Azure/azure-sdk-for-rust that referenced this pull request Mar 5, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#14353 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
@chidozieononiwu chidozieononiwu merged commit 137ef0f into Azure:main Mar 5, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants