Sync eng/common directory with azure-sdk-tools for PR 14353#9697
Merged
chidozieononiwu merged 2 commits intomainfrom Mar 5, 2026
Merged
Sync eng/common directory with azure-sdk-tools for PR 14353#9697chidozieononiwu merged 2 commits intomainfrom
chidozieononiwu merged 2 commits intomainfrom
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools (PR #14353), refactoring the npm registry reset logic from an inline pipeline step that deleted the .npmrc file into a reusable step template (reset-npmrc.yml) that explicitly sets the project-level npm registry using npm config set.
Changes:
- Added new reusable step template
reset-npmrc.ymlthat sets and verifies the npm registry at the project level with proper error handling. - Replaced the inline "Delete repo .npmrc" PowerShell task in
npm-publish.ymlwith a reference to the newreset-npmrc.ymltemplate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
eng/common/pipelines/templates/steps/reset-npmrc.yml |
New reusable step template that sets the project-level npm registry and verifies it was applied correctly. |
eng/common/pipelines/templates/jobs/npm-publish.yml |
Replaced inline .npmrc deletion step with a reference to the new reset-npmrc.yml template. |
chidozieononiwu
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14353 See eng/common workflow