Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14353#6986

Merged
chidozieononiwu merged 2 commits intomainfrom
sync-eng/common-AllowNpmJSAccess-14353
Mar 5, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14353#6986
chidozieononiwu merged 2 commits intomainfrom
sync-eng/common-AllowNpmJSAccess-14353

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14353 See eng/common workflow

Copilot AI review requested due to automatic review settings March 5, 2026 01:18
@azure-sdk azure-sdk requested a review from a team as a code owner March 5, 2026 01:18
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools PR #14353. It replaces an inline PowerShell step that deleted the repository .npmrc file before npm publishing with a reusable step template that explicitly sets the project-level npm registry and verifies it was applied correctly.

Changes:

  • Added a new reusable step template reset-npmrc.yml that sets and verifies the project-level npm registry using npm config set
  • Updated npm-publish.yml to use the new template instead of an inline script that deleted the .npmrc file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/common/pipelines/templates/steps/reset-npmrc.yml New reusable step template that sets the project npm registry via npm config set with error handling and verification
eng/common/pipelines/templates/jobs/npm-publish.yml Replaces inline .npmrc deletion step with a reference to the new reset-npmrc.yml template

@chidozieononiwu chidozieononiwu merged commit 22c897d into main Mar 5, 2026
21 of 53 checks passed
@chidozieononiwu chidozieononiwu deleted the sync-eng/common-AllowNpmJSAccess-14353 branch March 5, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants