Fix npm package URL transformation to handle versioned URLs and edge cases correctly #13307

Copilot · 2025-12-10T21:33:00Z

Summary

Successfully updated the npm URL replacement logic in eng/common/scripts/Verify-Links.ps1 to correctly handle both versioned and non-versioned npmjs package URLs.

Key Changes

Simplified regex pattern from ([^/]+(?:/[^/]+)?) to ([^?#]+) based on review feedback
Updated regex to properly exclude query parameters and URL fragments from transformation
Added comprehensive test coverage including edge cases (query params, fragments, trailing slashes)
Updated documentation to clarify how query parameters and fragments are handled
Enhanced test helper function documentation to explain its purpose

All 12 tests pass successfully. The implementation now correctly strips query parameters and fragments from URLs before transformation, ensuring accurate conversion to registry.npmjs.org URLs.

Original prompt

Update the link replacement logic introduced in PR #13281 to correctly handle npmjs package URLs for both versioned and non-versioned forms, with the following specific behavior:

Supported URL inputs:

Versioned npm package URLs (scoped or unscoped), e.g.:

https://www.npmjs.com/package/@azure/ai-agents/v/1.1.0

Non-versioned npm package URLs, e.g.:

https://www.npmjs.com/package/@azure/ai-agents

Required behavior:

Preserve the version specified in versioned URLs, but remove the literal "/v" path segment when rewriting. That is, rewrite

https://www.npmjs.com/package/@azure/ai-agents/v/1.1.0
to

https://www.npmjs.com/package/@azure/ai-agents/1.1.0

For non-versioned URLs, leave them as-is:

https://www.npmjs.com/package/@azure/ai-agents (no change)

Ensure scoped packages (@scope/package) and typical npm package naming edge cases (hyphens, numbers) are correctly handled.

Acceptance criteria:

The replacement logic correctly identifies npmjs package links with and without a version segment ("/v/") and treats both as valid targets.

Versioned URLs are rewritten to preserve the version while removing the "/v" segment as described.

Non-versioned URLs remain unchanged and valid.

Add/adjust unit tests to cover both URL types and edge cases, including multiple version patterns (e.g., "1.1.0", "1.1.0-beta.1").

Run the repo’s link-check workflow or tests locally (if applicable) to confirm there are no regressions.

Update documentation/comments in the replacement script to clarify supported npm URL formats and the "/v" removal rule.

Notes:

The prior merged PR (Fix link checks to npm for packages #13281) fixed link checks to npm for packages; use it as a reference to find the code path(s) that perform the npm URL handling and enhance them.

Coordinate with existing repository conventions (e.g., regex helpers or URL utilities) to avoid duplicate logic.

Consider making the version recognition robust (e.g., semver and common prerelease/build metadata), while maintaining simplicity.

This pull request was created as a result of the following prompt from Copilot chat.

Update the link replacement logic introduced in PR #13281 to correctly handle npmjs package URLs for both versioned and non-versioned forms, with the following specific behavior:

Supported URL inputs:

Versioned npm package URLs (scoped or unscoped), e.g.:

https://www.npmjs.com/package/@azure/ai-agents/v/1.1.0

Non-versioned npm package URLs, e.g.:

https://www.npmjs.com/package/@azure/ai-agents

Required behavior:

Preserve the version specified in versioned URLs, but remove the literal "/v" path segment when rewriting. That is, rewrite

https://www.npmjs.com/package/@azure/ai-agents/v/1.1.0
to

https://www.npmjs.com/package/@azure/ai-agents/1.1.0

For non-versioned URLs, leave them as-is:

https://www.npmjs.com/package/@azure/ai-agents (no change)

Ensure scoped packages (@scope/package) and typical npm package naming edge cases (hyphens, numbers) are correctly handled.

Acceptance criteria:

The replacement logic correctly identifies npmjs package links with and without a version segment ("/v/") and treats both as valid targets.

Versioned URLs are rewritten to preserve the version while removing the "/v" segment as described.

Non-versioned URLs remain unchanged and valid.

Add/adjust unit tests to cover both URL types and edge cases, including multiple version patterns (e.g., "1.1.0", "1.1.0-beta.1").

Run the repo’s link-check workflow or tests locally (if applicable) to confirm there are no regressions.

Update documentation/comments in the replacement script to clarify supported npm URL formats and the "/v" removal rule.

Notes:

The prior merged PR (Fix link checks to npm for packages #13281) fixed link checks to npm for packages; use it as a reference to find the code path(s) that perform the npm URL handling and enhance them.

Coordinate with existing repository conventions (e.g., regex helpers or URL utilities) to avoid duplicate logic.

Consider making the version recognition robust (e.g., semver and common prerelease/build metadata), while maintaining simplicity.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

weshaggard · 2025-12-11T19:00:21Z

eng/common/scripts/Verify-Links.ps1

+  # Handle non-versioned URLs: https://www.npmjs.com/package/@azure/ai-agents -> https://registry.npmjs.org/@azure/ai-agents
+  # The regex captures the package name (which may contain a slash for scoped packages) and optionally the version
+  $urlString = $linkUri.ToString()
+  if ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/([^/]+(?:/[^/]+)?)/v/(.+)$') {


Suggested change

if ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/([^/]+(?:/[^/]+)?)/v/(.+)$') {

if ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/(.+)/v/(.+)$') {

@copilot you can simplify this regex with the suggestion.

Simplified the regex pattern as suggested. Commit a36dad8 changes ([^/]+(?:/[^/]+)?) to (.+) in both the main code and test helper function. All tests pass with the simplified pattern.

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

weshaggard · 2025-12-11T19:08:01Z

/azp run azure-sdk-tools - sync - eng-common

azure-pipelines · 2025-12-11T19:08:12Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR fixes the npm package URL transformation logic in the link verification script to correctly handle versioned npm package URLs. The implementation removes the literal "/v/" path segment from versioned URLs while preserving the version number, and maintains non-versioned URLs unchanged.

Key Changes:

Updated regex-based URL transformation in ProcessNpmLink function to handle both versioned and non-versioned npm package URLs
Added comprehensive test suite with 8 test cases covering scoped packages, unscoped packages, URLs with/without "www" prefix, and version variations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
eng/common/scripts/Verify-Links.ps1	Replaced single-line regex transformation with conditional logic to handle versioned URLs (removing "/v/" segment) and non-versioned URLs separately
eng/common-tests/Verify-Links-ProcessNpmLink.Tests.ps1	Added new test file with 8 test cases validating URL transformations for various npm package URL formats

eng/common/scripts/Verify-Links.ps1

eng/common-tests/Verify-Links-ProcessNpmLink.Tests.ps1

eng/common/scripts/Verify-Links.ps1

eng/common-tests/Verify-Links-ProcessNpmLink.Tests.ps1

azure-sdk · 2025-12-11T19:16:43Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

weshaggard · 2025-12-11T19:38:08Z

/azp run azure-sdk-tools - sync - eng-common

azure-pipelines · 2025-12-11T19:38:18Z

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard · 2025-12-11T20:06:35Z

/azp run azure-sdk-tools - sync - eng-common

azure-pipelines · 2025-12-11T20:06:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2025-12-11T20:12:13Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13307 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

…cases correctly (#13307) * Initial plan * Fix npm URL replacement logic to handle versioned and non-versioned URLs Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com> * Refactor tests to reduce duplication with helper function Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com> * Simplify regex pattern as suggested by weshaggard Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com> * Fix regex to handle query params and fragments, add edge case tests Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com> * Improve test helper documentation per feedback Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

Initial plan

b135735

Copilot AI assigned Copilot and weshaggard Dec 10, 2025

Copilot started work on behalf of weshaggard December 10, 2025 21:33 View session

Copilot AI and others added 2 commits December 10, 2025 21:47

Fix npm URL replacement logic to handle versioned and non-versioned URLs

d040a06

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

Refactor tests to reduce duplication with helper function

b22fb96

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update link replacement logic for npm package URLs~~ Fix npm package URL transformation to handle versioned URLs correctly Dec 10, 2025

Copilot AI requested a review from weshaggard December 10, 2025 21:53

Copilot finished work on behalf of weshaggard December 10, 2025 21:53

weshaggard reviewed Dec 11, 2025

View reviewed changes

Copilot started work on behalf of weshaggard December 11, 2025 19:00 View session

Simplify regex pattern as suggested by weshaggard

a36dad8

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

weshaggard marked this pull request as ready for review December 11, 2025 19:08

weshaggard requested a review from a team as a code owner December 11, 2025 19:08

Copilot AI review requested due to automatic review settings December 11, 2025 19:08

Copilot started reviewing on behalf of weshaggard December 11, 2025 19:08 View session

Copilot AI requested a review from weshaggard December 11, 2025 19:08

Copilot finished work on behalf of weshaggard December 11, 2025 19:08

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Copilot started work on behalf of weshaggard December 11, 2025 19:17 View session

Fix regex to handle query params and fragments, add edge case tests

1585d74

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

Copilot AI changed the title ~~Fix npm package URL transformation to handle versioned URLs correctly~~ Fix npm package URL transformation to handle versioned URLs and edge cases correctly Dec 11, 2025

Copilot finished work on behalf of weshaggard December 11, 2025 19:24

Copilot started work on behalf of weshaggard December 11, 2025 19:24 View session

Improve test helper documentation per feedback

9c852d3

Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>

Copilot finished work on behalf of weshaggard December 11, 2025 19:35

weshaggard merged commit 55604df into main Dec 11, 2025
6 of 8 checks passed

weshaggard deleted the copilot/update-npm-url-replacement-logic branch December 11, 2025 22:54

weshaggard mentioned this pull request Jan 14, 2026

Fix ProcessNpmLink to handle non-versioned npm package URLs #13306

Closed

	if ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/([^/]+(?:/[^/]+)?)/v/(.+)$') {
	if ($urlString -match '^https?://(?:www\.)?npmjs\.com/package/(.+)/v/(.+)$') {

Fix npm package URL transformation to handle versioned URLs and edge cases correctly #13307

Fix npm package URL transformation to handle versioned URLs and edge cases correctly #13307

Uh oh!

Conversation

Copilot AI commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Uh oh!

weshaggard Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

weshaggard commented Dec 11, 2025

Uh oh!

azure-pipelines bot commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Dec 11, 2025

Uh oh!

weshaggard commented Dec 11, 2025

Uh oh!

azure-pipelines bot commented Dec 11, 2025

Uh oh!

weshaggard commented Dec 11, 2025

Uh oh!

azure-pipelines bot commented Dec 11, 2025

Uh oh!

azure-sdk commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 10, 2025 •

edited

Loading