Skip to content

Conversation

@weshaggard
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 9, 2025 22:05
@weshaggard weshaggard requested a review from a team as a code owner December 9, 2025 22:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes link verification for npm packages by working around Cloudflare 403 errors from npmjs.com. Instead of checking the package page directly, the script now uses the npmjs.org registry API for existence checks.

Key Changes:

  • Added special handling for npm package links via a new ProcessNpmLink function
  • Redirects npm package page URLs to the corresponding registry API URLs

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Dec 10, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13281 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Dec 10, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13281 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@weshaggard weshaggard merged commit c42859a into Azure:main Dec 10, 2025
10 checks passed
function ProcessNpmLink([System.Uri]$linkUri) {
# npmjs.com started using Cloudflare which returns 403 and we need to instead check the registry api for existence checks
# https://github.com/orgs/community/discussions/174098#discussioncomment-14461226
$apiUrl = $linkUri.ToString() -replace '^https?://(?:www\.)?npmjs\.com/package/(.*)/v', 'https://registry.npmjs.org/$1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you create a new PR that will update this replacement to support both version https://www.npmjs.com/package/@azure/ai-agents/v/1.1.0 and non-version npmjs urls https://www.npmjs.com/package/@azure/ai-agents?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants