Sync eng/common directory with azure-sdk-tools for PR 13307 #36865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: weshaggard <[email protected]>
Co-authored-by: weshaggard <[email protected]>
Co-authored-by: weshaggard <[email protected]>
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the eng/common directory with azure-sdk-tools (PR #13307), specifically updating the npm link verification logic to handle both versioned and non-versioned npm package URLs more robustly. The changes address issues with Cloudflare's 403 responses from npmjs.com by transforming URLs to use the npm registry API instead.
Key Changes
- Replaced a single-line regex replacement with conditional logic that handles versioned URLs (with
/v/segment) and non-versioned URLs separately - Added detailed comments explaining the URL transformation patterns and behavior
weshaggard
approved these changes
Dec 11, 2025
weshaggard
deleted the
sync-eng/common-copilot/update-npm-url-replacement-logic-13307
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13307 See eng/common workflow