Set-VcpkgWriteModeCache -- add token timeout param #12527
Merged
danieljurek merged 1 commit intomainfrom Oct 17, 2025
Merged
Conversation
…'s that exceed 1 hour (this can happen in C++ API View)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable token timeout support for vcpkg cache operations to handle long-running C++ API View builds that exceed the default 1-hour token expiration.
- Adds a
TokenTimeoutInHoursparameter (default: 1 hour) to the vcpkg cache configuration - Updates the SAS token generation to use the configurable timeout instead of hardcoded 1 hour
- Enables pipeline consumers to specify longer token lifetimes when needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Set-VcpkgWriteModeCache.ps1 | Adds TokenTimeoutInHours parameter and applies it to SAS token expiry |
| eng/common/pipelines/templates/steps/set-vcpkg-cache-vars.yml | Defines template parameter and passes it to the PowerShell script |
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Oct 16, 2025
weshaggard
approved these changes
Oct 16, 2025
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Oct 17, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12527 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Daniel Jurek <djurek@microsoft.com>
azure-sdk
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Oct 17, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12527 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Daniel Jurek <djurek@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (C++ API View) a
cmake generatetask can take multiple hours to complete successfully. In that time the storage token for the cache expires. While the job doesn't fail because of a cache authentication error, we lose the benefits of the cache.Example failure: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5425321&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=00170b8f-1061-5420-820e-1eb883d5ca57&l=200
Example of the pipeline working with a longer token timeout: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5462833&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=00170b8f-1061-5420-820e-1eb883d5ca57&l=106