Conversation
…'s that exceed 1 hour (this can happen in C++ API View)
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools PR #12527, adding configurability for the SAS token expiry time in the vcpkg cache setup. Previously, the token expiry was hardcoded to 1 hour.
- Adds a
TokenTimeoutInHoursparameter with a default value of 1 hour to both the PowerShell script and YAML template - Updates the SAS token generation to use the configurable timeout instead of a hardcoded value
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Set-VcpkgWriteModeCache.ps1 | Adds TokenTimeoutInHours parameter and uses it for SAS token expiry |
| eng/common/pipelines/templates/steps/set-vcpkg-cache-vars.yml | Adds TokenTimeoutInHours parameter and passes it to the PowerShell script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
danieljurek
approved these changes
Oct 17, 2025
azure-sdk
deleted the
sync-eng/common-djurek/vcpkg-cache-timeout-param-12527
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12527 See eng/common workflow