Sync eng/common directory with azure-sdk-tools for PR 12527#25445
Merged
Sync eng/common directory with azure-sdk-tools for PR 12527#25445
Conversation
…'s that exceed 1 hour (this can happen in C++ API View)
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools for PR 12527, adding configurable token timeout functionality to vcpkg cache management. The changes make the previously hardcoded 1-hour SAS token expiration time configurable through a new parameter.
Key changes:
- Added configurable token timeout parameter to vcpkg cache scripts
- Updated PowerShell script to accept TokenTimeoutInHours parameter
- Modified Azure pipeline template to pass the timeout parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Set-VcpkgWriteModeCache.ps1 | Added TokenTimeoutInHours parameter and replaced hardcoded timeout value |
| eng/common/pipelines/templates/steps/set-vcpkg-cache-vars.yml | Added parameter definition and script argument for token timeout configuration |
danieljurek
approved these changes
Oct 17, 2025
azure-sdk
deleted the
sync-eng/common-djurek/vcpkg-cache-timeout-param-12527
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12527 See eng/common workflow