Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
b03e643 to
bd585f3
Compare
swathipil
left a comment
There was a problem hiding this comment.
looks good for SR/SB - thanks!
scbedd
left a comment
There was a problem hiding this comment.
I am so excited to see this code getting cleaned up!
Is the rename of test_mgmt_documentdb to disable_test_mgmt_documentdb to make it so the file doesn't get picked up by pytest anymore? Or was this something that needed to be cleaned up?
If you intended the rename, maybe we just delete the file?
Other than that, looks reasonable to me! Thanks @mccoyp !
@scbedd Yep, that's exactly the intention. This pattern actually started a while back, when we started migrating en masse to the test proxy -- some mgmt libraries didn't have functional tests, so instead of updating imports and inheritances, we decided to exclude the tests from being loaded at testing time. Now that it's been so long, we probably could start removing these tests instead of having the vestigial bloat. I just want to check with library owners before doing so, at which point we can just do a wider purge -- at least, that's what I was thinking. |
👍 I understand. I tend to think that every dev will err on the side of
but it's probably just FUD. You're not wrong to toss the question at em though 💯 |
|
/check-enforcer override |
Description
Now that the repository has moved away from using
vcrpy, we don't have a reason to continue supportingAzure(Mgmt)TestCaseclasses;Azure(Mgmt)RecordedTestCaseclasses have the same core functionality, without making references to old recording infrastructure.The last functional use of
AzureMgmtTestCaseis inazure-batch, since they're still migrating to track 2. Using the new test class instead still turned out to be possible (without recording capability), so that migration is handled in #33388. This PR removes the SDK's remaining, non-functional references.Note: CI failures on this PR are unrelated to these changes.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines