Skip to content

[Batch] Migrate to new test class inheritance and structure#33388

Merged
mccoyp merged 2 commits intoAzure:mainfrom
mccoyp:batch-test-case
Dec 13, 2023
Merged

[Batch] Migrate to new test class inheritance and structure#33388
mccoyp merged 2 commits intoAzure:mainfrom
mccoyp:batch-test-case

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Dec 4, 2023

Description

This PR updates test_batch.py to have its test class inherit from AzureMgmtRecordedTestCase instead of AzureMgmtTestCase. The former class is necessary for test proxy use, which Batch will eventually migrate to as part of track 2 migration. Tests functionally work the same as before, but now use pytest-style assertions instead of unittest.TestCase ones.

AzureMgmtTestCase, and other test tooling that predates the test proxy, will soon be removed from the Python repository. Since vcrpy scrubbers are also no longer used in SDK tests, portions of test tooling that reference scrubbers have either been removed or updated to reference test proxy sanitizers.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added Batch Client This issue points to a problem in the data-plane of the library. test-enhancement labels Dec 4, 2023
@mccoyp mccoyp marked this pull request as ready for review December 4, 2023 23:01
@mccoyp mccoyp mentioned this pull request Dec 5, 2023
6 tasks
Copy link
Member

@wiboris wiboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mccoyp mccoyp merged commit 630b103 into Azure:main Dec 13, 2023
@mccoyp mccoyp deleted the batch-test-case branch December 13, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Batch Client This issue points to a problem in the data-plane of the library. test-enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments