Conversation
|
Thank you for your contribution @akx! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes disabled test files that have been inactive since 2018-2023. All files are clearly marked as disabled through either disable_ filename prefixes, @unittest.skip/@pytest.mark.skip decorators, or raise unittest.SkipTest() statements at module level.
Changes:
- Removes 8 disabled test files from the Service Bus management SDK
- Removes 1 disabled test file from Resource Graph SDK
- Removes 1 disabled test file from Media Services SDK
- Removes 1 disabled test file from Event Grid SDK
- Removes 1 disabled test file from Consumption SDK
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_cli_mgmt_servicebus_namespace.py | Removed disabled namespace tests with @unittest.skip decorators |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_cli_mgmt_servicebus.py | Removed disabled CLI management tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic_subscription_rule.py | Removed disabled topic subscription rule tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic_subscription.py | Removed disabled topic subscription tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic.py | Removed disabled topic tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_queue.py | Removed disabled queue tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_namespace.py | Removed disabled namespace tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_check_name_availability.py | Removed disabled name availability check tests with disable_ prefix |
| sdk/resources/azure-mgmt-resourcegraph/tests/test_mgmt_resourcegraph.py | Removed resource graph tests skipped with @pytest.mark.skip |
| sdk/media/azure-mgmt-media/tests/test_mgmt_media.py | Removed media tests with raise unittest.SkipTest |
| sdk/eventgrid/azure-mgmt-eventgrid/tests/test_azure_mgmt_eventgrid_test.py | Removed event grid tests with raise unittest.SkipTest |
| sdk/consumption/azure-mgmt-consumption/tests/test_mgmt_consumption.py | Removed consumption tests with raise unittest.SkipTest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes test code that has been disabled in:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines