Generate Microsoft.PolicyInsights SDK from latest swagger#8911
Merged
isra-fel merged 5 commits intoAzure:masterfrom Dec 4, 2019
eladperets:master
Merged
Generate Microsoft.PolicyInsights SDK from latest swagger#8911isra-fel merged 5 commits intoAzure:masterfrom eladperets:master
isra-fel merged 5 commits intoAzure:masterfrom
eladperets:master
Conversation
- Added policy metadata (new resource type) tests - Update existing tests for new API versions (remediation and policy states)
eladperets
commented
Nov 25, 2019
...ghts/Microsoft.Azure.Management.PolicyInsights/src/Generated/SdkInfo_PolicyInsightsClient.cs
Outdated
Show resolved
Hide resolved
isra-fel
requested changes
Dec 3, 2019
Member
There was a problem hiding this comment.
Hi @eladperets , sorry for the delay. Could you
- Add a link to the swagger spec review PR in the description
- Include the
.txtfile generated when you rungenerate.ps1(details) - Update api tag in
AzSdk.RP.props, release notes in csproj - Update versions in csproj and
assemblyinfo.csif you are going to release
Thanks
- Incremented the major version because the new SDK removed a call that was available in previous versions
Contributor
Author
Done |
isra-fel
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swagger PRs:
Azure/azure-rest-api-specs#7675
Azure/azure-rest-api-specs#7717
Azure/azure-rest-api-specs#7505