Adding PolicyInsights policyStates api version 2019-10-01. by sandipsh · Pull Request #7505 · Azure/azure-rest-api-specs

sandipsh · 2019-10-15T18:03:25Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-10-15T18:03:29Z

In Testing, Please Ignore

[Logs] (Generated from 33073ab, Iteration 10)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

AutorestCI · 2019-10-15T18:04:43Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7966

azuresdkci · 2019-10-15T18:04:54Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-15T18:08:29Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6069

specification/policyinsights/resource-manager/readme.md

weidongxu-microsoft · 2019-10-16T01:34:03Z

I am good with it (there is no API change). Please confirm on my last comment on whether you would like to put other json into package-2019-10. Then we could merge.

… Also updated policyStates.json as per latest API changes.

weidongxu-microsoft · 2019-10-16T05:44:24Z

To ARM review. Commit changing the API is the last one 964ec29.

...ts/stable/2019-10-01/examples/PolicyStates_QueryResourceGroupLevelPolicyAssignmentScope.json

...ce-manager/Microsoft.PolicyInsights/stable/2019-10-01/examples/PolicyStates_GetMetadata.json

...ft.PolicyInsights/stable/2019-10-01/examples/PolicyStates_SummarizeManagementGroupScope.json

...table/2019-10-01/examples/PolicyStates_SummarizeResourceGroupLevelPolicyAssignmentScope.json

.../stable/2019-10-01/examples/PolicyStates_QuerySubscriptionLevelPolicySetDefinitionScope.json

cemheren · 2019-10-16T18:22:12Z

...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json

+            "$ref": "#/parameters/filterParameter"
+          },
+          {
+            "$ref": "#/parameters/applyParameter"


what about expand for this

There's a separate path with expandParameter at resourceId scope that we currently support. I believe it's not supported at other scopes.

In reply to: 335637526 [](ancestors = 335637526)

majastrz

Looks good from ARM side.

weidongxu-microsoft · 2019-10-17T01:30:31Z

/azp run

azure-pipelines · 2019-10-17T01:30:47Z

Azure Pipelines successfully started running 2 pipeline(s).

adding a baseline folder for PolicyInsights 2019-10-01

10b2619

azuresdkci assigned weidongxu-microsoft Oct 15, 2019

azuresdkci requested a review from weidongxu-microsoft October 15, 2019 18:04

AutorestCI mentioned this pull request Oct 15, 2019

[AutoPR policyinsights/resource-manager] Adding a baseline folder for PolicyInsights 2019-10-01. Contents are same as prior version, I will make changes once this PR is complete. Azure/azure-sdk-for-python#7902

Merged

sandipsh added 2 commits October 15, 2019 11:39

fixing validation errors.

0c35e4c

fix go build error

12e9be1

fix go build error

551a94e

AutorestCI mentioned this pull request Oct 15, 2019

[AutoPR policyinsights/resource-manager] Adding a baseline folder for PolicyInsights 2019-10-01. Contents are same as prior version, I will make changes once this PR is complete. Azure/azure-sdk-for-go#6041

Merged

weidongxu-microsoft approved these changes Oct 16, 2019

View reviewed changes

weidongxu-microsoft reviewed Oct 16, 2019

View reviewed changes

specification/policyinsights/resource-manager/readme.md Show resolved Hide resolved

Added spec json files for other resources to be added to the package.…

964ec29

… Also updated policyStates.json as per latest API changes.

sandipsh changed the title ~~Adding a baseline folder for PolicyInsights 2019-10-01. Contents are same as prior version, I will make changes once this PR is complete.~~ Adding PolicyInsights policyStates api version 2019-10-01. Oct 16, 2019

weidongxu-microsoft self-requested a review October 16, 2019 05:38

weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2019

cemheren requested changes Oct 16, 2019

View reviewed changes

Added new columns in the examples. Also, Removed metadata path.

33073ab

cemheren approved these changes Oct 16, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2019

majastrz approved these changes Oct 17, 2019

View reviewed changes

weidongxu-microsoft merged commit 9baf9b6 into Azure:master Oct 17, 2019

eladperets mentioned this pull request Dec 3, 2019

Generate Microsoft.PolicyInsights SDK from latest swagger Azure/azure-sdk-for-net#8911

Merged

Conversation

sandipsh commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 33073ab, Iteration 10)

Uh oh!

AutorestCI commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Oct 15, 2019

Uh oh!

AutorestCI commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

weidongxu-microsoft commented Oct 16, 2019

Uh oh!

weidongxu-microsoft commented Oct 16, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cemheren Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

sandipsh Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

weidongxu-microsoft commented Oct 17, 2019

Uh oh!

azure-pipelines bot commented Oct 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sandipsh commented Oct 15, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 15, 2019 •

edited

Loading

AutorestCI commented Oct 15, 2019 •

edited

Loading

AutorestCI commented Oct 15, 2019 •

edited

Loading