Skip to content

Microsoft.PolicyInsights/remediations 2019-07-01#7717

Merged
fengzhou-msft merged 4 commits intoAzure:masterfrom
pilor:remediation20190701
Nov 12, 2019
Merged

Microsoft.PolicyInsights/remediations 2019-07-01#7717
fengzhou-msft merged 4 commits intoAzure:masterfrom
pilor:remediation20190701

Conversation

@pilor
Copy link
Contributor

@pilor pilor commented Nov 5, 2019

Adds the resourceDiscoveryMode enum to the remediations API in Microsoft.PolicyInsights. This allows remediations to discover non-compliant resources and remediate them in one call (optionally). Previously, non-compliant resources had to be known prior to remediation starting.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@pilor pilor added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 5, 2019
@AutorestCI
Copy link

AutorestCI commented Nov 5, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8400

@AutorestCI
Copy link

AutorestCI commented Nov 5, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6262

@pilor pilor requested a review from sandipsh November 5, 2019 23:51
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 5, 2019
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed off from ARM side.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@pilor pilor force-pushed the remediation20190701 branch from 84ce9e7 to dedfff1 Compare November 6, 2019 00:17
Copy link
Contributor

@sandipsh sandipsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pilor
Copy link
Contributor Author

pilor commented Nov 6, 2019

@myronfanqiu Looks like an SDK reviewer didn't get assigned to this PR. Can you assign someone appropriate?

@pilor
Copy link
Contributor Author

pilor commented Nov 11, 2019

@fengzhou-msft comments resolved

@fengzhou-msft fengzhou-msft merged commit 25027ef into Azure:master Nov 12, 2019
solhaile pushed a commit to solhaile/azure-rest-api-specs that referenced this pull request Nov 13, 2019
* Copy 2018-07-01-preview to 2019-07-01

* Update spec and examples

* Change rg name in examples

* Fix readme path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Reassign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments