[Databox] SDK refresh to support new API version (2019-09-01)#8176
Closed
sashanm wants to merge 22 commits into
Closed
[Databox] SDK refresh to support new API version (2019-09-01)#8176sashanm wants to merge 22 commits into
sashanm wants to merge 22 commits into
Conversation
* Refreshing SDK with support for new API version
Contributor
|
Can one of the admins verify this patch? |
* Added recorded tests
AMQP Foundation
- Updates and extensions to common areas, primarily around AMQP links and
connections infrastructure.
- Implementation of the AMQP Event Hub producer.
- Tweaks and fixes across the foundation for issues discovered during
end-to-end testing of Event Hub client and producer types.
General
- Formatting pass across the client library and tests.
- Incorporation of logging for operations and key background activities.
…pe from public to internal (Azure#8164)
AMQP Foundation
- Adding an idle timeout to the AMQP connection to ensure that it does
not hang in an inconsistent state on some platforms.
(see: Azure#7944)
- Restructuring of retry loops for service operations for more uniform
exception handling and logging.
- Adjusted close for client types to mark the object as closed before
taking any action to ensure that the instance is not usable for normal
operations while in a closing state; this will revert should an
exception occur to allow for attempting to close again.
- Removing unused annotations type; the members used have been folded into
the AMQP Properties class, where they are a more logical fit.
- General light tweaking and tuning AMQP-related constructs for efficiency
and to normalize patterns.
[Storage] Rename IPRange to SasIPRange
* fix-issue-8171 * Adding tests.
The CI is actually green.
The convention is to use ".lockfile" and not ".lock" when accessing the shared MSAL cache.
isra-fel
requested changes
Oct 18, 2019
| <!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file--> | ||
| <PropertyGroup> | ||
| <AzureApiTag>DataBox_2018-01-01;</AzureApiTag> | ||
| <AzureApiTag>DataBox_2018-01-01;DataBox_2019-09-01;</AzureApiTag> |
Member
There was a problem hiding this comment.
Is there any reason you don't want DataBox_2018-01-01; to be removed?
| <Description>Microsoft Azure Management DataBox library</Description> | ||
| <AssemblyName>Microsoft.Azure.Management.DataBox</AssemblyName> | ||
| <Version>1.0.1</Version> | ||
| <Version>1.2.0</Version> |
Contributor
Author
There was a problem hiding this comment.
Since we didn't refresh our SDK for an year now. We want to bump the version to 1.2.0
Member
There was a problem hiding this comment.
Time shouldn't be the reason to skip a minor version number.
|
|
||
| 5) Fetching list of available skus in Data Box family based on customer location | ||
|
|
||
| 6) Validating Job creation inputs and its supportability by Azure Data Box service |
Member
There was a problem hiding this comment.
Are the above 5 notes from last release or for this release? If last, I believe you should remve them.
Contributor
Author
There was a problem hiding this comment.
If I understand you correctly, You want only the changes in this PR to be mentioned here
isra-fel
added
Mgmt
sashanm
requested review from
AlexGhiondea,
amnguye,
annelo-msft,
chidozieononiwu,
danieljurek and
jsquire
as code owners
sashanm
requested review from
kinelski,
mitchdenny,
pakrym,
seanmcc-msft,
serkantkaraca,
tg-msft and
weshaggard
as code owners
* Refreshing SDK with support for new API version
* Added recorded tests
Contributor
Author
|
Creating new pull request since sync repo added other commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure API spec PR : Azure/azure-rest-api-specs#7317