Skip to content

[Databox] SDK refresh to support new API version (2019-09-01)#8219

Merged
isra-fel merged 10 commits into
Azure:masterfrom
AzureDataBox:master
Oct 23, 2019
Merged

[Databox] SDK refresh to support new API version (2019-09-01)#8219
isra-fel merged 10 commits into
Azure:masterfrom
AzureDataBox:master

Conversation

@sashanm
Copy link
Copy Markdown
Contributor

@sashanm sashanm commented Oct 18, 2019

@sashanm sashanm requested a review from erich-wang as a code owner October 18, 2019 10:30
@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@sashanm
Copy link
Copy Markdown
Contributor Author

sashanm commented Oct 18, 2019

@isra-fel : I closed PR #8176 since it was showing others commit as well somehow. so, I have created a new PR and addressed your code review comments in it. Please take a look and let me know If you have any concerns

Thanks

@isra-fel isra-fel closed this Oct 21, 2019
@isra-fel isra-fel reopened this Oct 21, 2019
@isra-fel isra-fel self-assigned this Oct 21, 2019
<Description>Microsoft Azure Management DataBox library</Description>
<AssemblyName>Microsoft.Azure.Management.DataBox</AssemblyName>
<Version>1.0.1</Version>
<Version>1.2.0</Version>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, please use 1.1.0


[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyFileVersion("1.0.1")]
[assembly: AssemblyFileVersion("1.2.0")]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision and removed needs-review labels Oct 21, 2019
@isra-fel isra-fel assigned sashanm and unassigned isra-fel Oct 21, 2019
@sashanm sashanm removed their assignment Oct 22, 2019
Comment thread sdk/databox/Microsoft.Azure.Management.DataBox/src/Properties/AssemblyInfo.cs Outdated
@sashanm sashanm removed their assignment Oct 22, 2019
@isra-fel isra-fel merged commit 4bee048 into Azure:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants