Turn large or mutable structs back into classes#8178
Merged
pakrym merged 6 commits intoOct 17, 2019
Conversation
pakrym
force-pushed
the
pakrym/large-mutable-structs-classes
branch
from
a3cf6f9 to
46fd82e
Compare
pakrym
changed the title
pakrym
requested review from
amnguye,
seanmcc-msft and
tg-msft
as code owners
tg-msft
reviewed
Oct 17, 2019
Member
|
I think BlobRestClient wasn't regenerated after AccountInfo change. AccountInfo should be a class, correct? I can merge this in my PR, but just wanted to make sure. |
Member
|
Yes, @JoshLove-msft, there's a separate fix out for that but feel free to merge it if you're going in first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #6897.