Skip to content

SQL Private Endpoint Connections SDK#7410

Merged
isra-fel merged 8 commits intoAzure:masterfrom
beoberha:privateendpointconnections
Sep 6, 2019
Merged

SQL Private Endpoint Connections SDK#7410
isra-fel merged 8 commits intoAzure:masterfrom
beoberha:privateendpointconnections

Conversation

@beoberha
Copy link
Contributor

@beoberha beoberha commented Aug 27, 2019

@beoberha beoberha requested a review from erich-wang as a code owner August 27, 2019 18:23
@beoberha
Copy link
Contributor Author

Need to regenerate once Swagger is merged

@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision labels Aug 28, 2019
@isra-fel
Copy link
Member

Hi @beoberha
Please add a link to the swagger PR in description and, when you regenrate, follow the instructions and make sure you git add the txt metadata file.

Thanks

@beoberha beoberha changed the title Private Endpoint SDK initial commit SQL Private Endpoint Connections SDK Sep 3, 2019
@beoberha
Copy link
Contributor Author

beoberha commented Sep 4, 2019

@isra-fel Can you please take a look. Tests are all now passing and I believe I have addressed your concerns.

@isra-fel isra-fel merged commit 7869fae into Azure:master Sep 6, 2019
JoshLove-msft pushed a commit to JoshLove-msft/azure-sdk-for-net that referenced this pull request Sep 10, 2019
* Private Endpoint SDK initial commit

* Bump nuget version

* generate from master

* fix sql_resource-manager.txt

* Fix tests broken by Network nuget bump

* Re-bump nuget version

* Fix merge issue with SqlManagementClient.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants