private link resources swagger by beoberha · Pull Request #6866 · Azure/azure-rest-api-specs

beoberha · 2019-08-05T22:05:30Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-05T22:05:33Z

In Testing, Please Ignore

[Logs] (Generated from df33ca9, Iteration 3)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-sql [Logs] [Instructions] [Generation PR]
- azure-mgmt-sql-0.12.0.zip
- azure_mgmt_sql-0.12.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

sql/resource-manager/v2014_04_01 [Logs] [Instructions] [Generation PR]
sql/resource-manager/v2015_05_01_preview [Logs]
sql/resource-manager/v2017_03_01_preview [Logs]
sql/resource-manager/v2017_10_01_preview [Logs]
sql/resource-manager/v2018_06_01_preview [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/sql/mgmt/2015-05-01-preview [Logs]
preview/sql/mgmt/2017-03-01-preview [Logs]
preview/sql/mgmt/2017-10-01-preview [Logs]
sql/mgmt/2014-04-01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-sql [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-arm-sql-5.7.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-08-05T22:09:04Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6919

AutorestCI · 2019-08-05T22:12:12Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-08-05T23:09:04Z

Can one of the admins verify this patch?

jaredmoo · 2019-08-06T20:11:50Z

Looks good, waiting for Ben to give signal that it's ready to merge.

ravbhatnagar · 2019-08-07T07:29:42Z

...tion/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateLinkResources.json

+              "$ref": "#/definitions/PrivateLinkResourceListResult"
+            }
+          },
+          "default": {


please start including the default response. @jaredmoo - any ETA when SQL can start including the default response where the schema complies with th ARM error contract schema?

ravbhatnagar · 2019-08-07T07:36:34Z

...tion/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateLinkResources.json

+      "description": "Properties of a private link resource.",
+      "type": "object",
+      "properties": {
+        "groupId": {


is this resource group id as indicated in the description or something else? from the example, it doesnt seem like this is the resource group id.

GroupId is not related to Resource Groups in any way. GroupId represents different endpoints that a service can be accessed. Azure Networking's PrivateLink feature is being implemented by many services and during creation of PrivateLink you need to specify which "group" or endpoint you want to create the link against. For example, CosmosDB has an endpoint for MongoDB and an endpoint for Cassandra. Thus there are two "groups" that can be chosen. This API is a utility API that lists them.

SQL is a bit trivial because we only have one endpoint and thus one group.

ravbhatnagar · 2019-08-07T07:36:50Z

...tion/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateLinkResources.json

+          "type": "string",
+          "readOnly": true
+        },
+        "requiredMembers": {


what are some examples of members?

Members are sub sections of groups. I am not completely positive how they work honestly because SQL only has one group and one member: "sqlServer"

ravbhatnagar · 2019-08-07T07:37:08Z

...tion/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateLinkResources.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/privateLinkResources/{groupName}": {


how is a private link resource created?

how is the groupName parameter in the URL different from the groupId parameter in the body?

So this API doesn't map to any actual resource. This API is a utility to allow customers to be able to pass the proper "groupId" and "memberName" parameters to PUT PrivateEndpoint. Since groupId and memberName are different for each service, all implementing services have to implement this API. It is defined in section 6.4 in the NRP Spec.

Since SQL has only one groupId and member, we just return static values.

ravbhatnagar · 2019-08-07T07:38:17Z

@beoberha - few comments, please take a look.

ravbhatnagar · 2019-08-12T17:32:56Z

Signing off from ARM side.

jhendrixMSFT · 2019-08-12T17:58:00Z

Looks good from SDK perspective, please let me know when this has been deployed and is ready for merge.

jhendrixMSFT · 2019-08-20T21:39:10Z

@beoberha has this been deployed yet?

beoberha · 2019-08-27T18:51:43Z

@jhendrixMSFT This is ready for merging now

private link resources swagger

df33ca9

beoberha requested a review from jaredmoo as a code owner August 5, 2019 22:05

azuresdkci assigned jhendrixMSFT Aug 5, 2019

azuresdkci requested a review from jhendrixMSFT August 5, 2019 22:06

AutorestCI mentioned this pull request Aug 5, 2019

[AutoPR sql/resource-manager] private link resources swagger Azure/azure-sdk-for-python#6667

Closed

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 5, 2019

beoberha changed the title ~~private link resources swagger~~ [DO NOT MERGE] private link resources swagger Aug 6, 2019

ravbhatnagar reviewed Aug 7, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested label Aug 7, 2019

ravbhatnagar mentioned this pull request Aug 8, 2019

[Hub Generated] Review request for Microsoft.ContainerService to add version stable/2019-08-01 #6859

Merged

2 tasks

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2019

PhoenixHe-NV mentioned this pull request Aug 16, 2019

[Mirror] [DO NOT MERGE] private link resources swagger test-repo-tih/azure-rest-api-specs#132

Closed

beoberha changed the title ~~[DO NOT MERGE] private link resources swagger~~ private link resources swagger Aug 27, 2019

openapi-sdkautomation bot mentioned this pull request Aug 27, 2019

[AutoPR sql/resource-manager/v2014_04_01] private link resources swagger test-repo-billy/azure-sdk-for-java#266

Closed

jhendrixMSFT approved these changes Aug 27, 2019

View reviewed changes

jhendrixMSFT merged commit 7f5ee6d into Azure:master Aug 27, 2019

AutorestCI mentioned this pull request Aug 27, 2019

[AutoPR sql/resource-manager] private link resources swagger Azure/azure-sdk-for-python#6952

Merged

beoberha mentioned this pull request Sep 3, 2019

SQL Private Endpoint Connections SDK Azure/azure-sdk-for-net#7410

Merged

ramnov mentioned this pull request Oct 1, 2019

Add PrivateEndpointConnection, PrivateLinkResources swagger #7372

Closed

5 tasks

Conversation

beoberha commented Aug 5, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from df33ca9, Iteration 3)

Uh oh!

AutorestCI commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Aug 5, 2019

Uh oh!

jaredmoo commented Aug 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Aug 7, 2019

Uh oh!

ravbhatnagar commented Aug 12, 2019

Uh oh!

jhendrixMSFT commented Aug 12, 2019

Uh oh!

jhendrixMSFT commented Aug 20, 2019

Uh oh!

beoberha commented Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation bot commented Aug 5, 2019 •

edited

Loading

AutorestCI commented Aug 5, 2019 •

edited

Loading

AutorestCI commented Aug 5, 2019 •

edited

Loading

beoberha commented Aug 27, 2019 •

edited

Loading