Add PrivateEndpointConnection Swagger by beoberha · Pull Request #6727 · Azure/azure-rest-api-specs

beoberha · 2019-07-25T17:21:41Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-07-25T17:21:44Z

In Testing, Please Ignore

[Logs] (Generated from b26f09a, Iteration 14)

AutorestCI · 2019-07-25T17:23:52Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6919

azuresdkci · 2019-07-25T17:30:54Z

Can one of the admins verify this patch?

AutorestCI · 2019-07-25T17:33:40Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

jaredmoo · 2019-07-30T18:28:36Z

...tion/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateLinkResources.json

+      ],
+      "properties": {}
+    },
+    "PrivateLink": {


Please check with Mario whether this should be PrivateLink vs PrivateLinkResource

Discussed with Bo from NRP and he said we should use PrivateLinkResource. Fixed in most recent commit.

jaredmoo · 2019-07-30T18:29:41Z

specification/sql/resource-manager/readme.md

 - Microsoft.Sql/preview/2018-06-01-preview/managedInstances.json
 - Microsoft.Sql/preview/2018-06-01-preview/FailoverDatabases.json
 - Microsoft.Sql/preview/2018-06-01-preview/FailoverElasticPools.json
+- Microsoft.Sql/preview/2018-06-01-preview/PrivateEndpointConnections.json


Please also add to package-composite-v3

jaredmoo · 2019-07-31T18:14:13Z

...tion/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateLinkResources.json

+    }
+  },
+  "definitions": {
+    "PrivateLinkListResult": {


PrivateLinkResourceListResult

removed from this PR. Will address when I create PLR PR

jaredmoo · 2019-07-31T18:17:44Z

...nager/Microsoft.Sql/preview/2018-06-01-preview/examples/PrivateEndpointConnectionUpdate.json

+      "properties": {
+        "privateLinkServiceConnectionState": {
+          "status": "Approved",
+          "description":  "Approved by johndoe@company.com"


You know company.com is real? I don't think they want us to use them as an example ;) Please use known examples such as contoso or example.com. "admin@example.com" would be perfect.

removed from this PR. Will address when I create PLR PR

jaredmoo · 2019-08-06T20:02:29Z

...ql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateEndpointConnections.json

+        },
+        "privateLinkServiceConnectionState": {
+          "$ref": "#/definitions/PrivateLinkServiceConnectionStateProperty",
+          "description": "Connection State of the Private Endpoint Connection."


Nit: capitalization is only for products (e.g. "Azure SQL Database"), not product features ("private endpoint connection"). Please find & replace.

beoberha · 2019-08-27T18:51:02Z

This is ready for merging now

beoberha · 2019-08-27T18:56:18Z

@sergey-shandar could you approve/merge pls

...ql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateEndpointConnections.json

anthony-c-martin · 2019-08-28T22:26:52Z

...ql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateEndpointConnections.json

+        }
+      }
+    },
+    "PrivateEndpointProperty": {


Can you mark this as a resource id? See

azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/network.json

Line 137 in a3a5331

"SubResource": {

as an example

@jaredmoo is this possible with our Framework?

Anthony, can you clarify which part of the example you are referring to? Is it x-ms-azure-resource: true?

Yup, sorry - my comment wasn't very clear. I'm just referring to x-ms-azure-resource: true

anthony-c-martin · 2019-08-28T22:27:32Z

...ql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateEndpointConnections.json

+          "type": "string"
+        },
+        "actionsRequired": {
+          "description": "The private link service connection description.",


Update description

...ql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/PrivateEndpointConnections.json

…rha/azure-rest-api-specs into privateendpointconnections

beoberha added 2 commits July 25, 2019 09:50

Add PrivateEndpointConnection Swagger

9478d79

Adding examples

dcab6ea

beoberha requested a review from jaredmoo as a code owner July 25, 2019 17:21

azuresdkci assigned sergey-shandar Jul 25, 2019

azuresdkci requested a review from sergey-shandar July 25, 2019 17:23

openapi-sdkautomation bot mentioned this pull request Jul 25, 2019

[AutoPR @azure/arm-sql] [DO NOT MERGE] Add PrivateEndpointConnection Swagger Azure/azure-sdk-for-js#4430

Closed

Fix to pass validation

147606b

beoberha added 3 commits July 25, 2019 15:51

PrivateLinkResources

8ceb447

Accidentally put PrivateLinkResourceGet.json in wrong place

3d7f52e

Add PEC files to readme

b92e63b

jaredmoo suggested changes Jul 30, 2019

View reviewed changes

beoberha added 2 commits July 31, 2019 09:51

add new swagger files to package-composite-v3

771f67a

update PrivateLinkResource swagger file

470e555

AutorestCI mentioned this pull request Jul 31, 2019

[AutoPR sql/resource-manager] [DO NOT MERGE] Add PrivateEndpointConnection Swagger Azure/azure-sdk-for-python#6580

Closed

Added incorrect PrivateLinkResource swagger file

82ae9c2

jaredmoo reviewed Jul 31, 2019

View reviewed changes

beoberha added 3 commits July 31, 2019 16:29

fix lintdiff validation errors

6fef072

remove PrivateLinkResources from this PR

7355a9c

forgot to update example

9930f56

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 5, 2019

Update PEC swagger for BO

6b1c97b

jaredmoo approved these changes Aug 6, 2019

View reviewed changes

beoberha changed the title ~~[DO NOT MERGE] Add PrivateEndpointConnection Swagger~~ Add PrivateEndpointConnection Swagger Aug 27, 2019

Merge branch 'master' into privateendpointconnections

615dd20

AutorestCI mentioned this pull request Aug 27, 2019

[AutoPR sql/resource-manager] Add PrivateEndpointConnection Swagger Azure/azure-sdk-for-python#6962

Closed

zikalino self-assigned this Aug 27, 2019

anthony-c-martin requested changes Aug 28, 2019

View reviewed changes

beoberha added 2 commits August 30, 2019 11:38

address Anthony's comments

71be652

Merge branch 'privateendpointconnections' of https://github.com/beobe…

b26f09a

…rha/azure-rest-api-specs into privateendpointconnections

anthony-c-martin approved these changes Aug 30, 2019

View reviewed changes

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 30, 2019

sergey-shandar approved these changes Aug 30, 2019

View reviewed changes

sergey-shandar merged commit 16e9a4f into Azure:master Aug 30, 2019

beoberha mentioned this pull request Sep 3, 2019

SQL Private Endpoint Connections SDK Azure/azure-sdk-for-net#7410

Merged

ramnov mentioned this pull request Oct 1, 2019

Add PrivateEndpointConnection, PrivateLinkResources swagger #7372

Closed

5 tasks

Conversation

beoberha commented Jul 25, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from b26f09a, Iteration 14)

Uh oh!

AutorestCI commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Jul 25, 2019

Uh oh!

AutorestCI commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beoberha commented Aug 27, 2019

Uh oh!

beoberha commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openapi-sdkautomation bot commented Jul 25, 2019 •

edited

Loading

AutorestCI commented Jul 25, 2019 •

edited

Loading

AutorestCI commented Jul 25, 2019 •

edited

Loading