Skip to content

[AutoPR Azure.ResourceManager.AppNetwork]-generated-from-SDK Generation - .NET-6060192#57448

Merged
deveshdama merged 15 commits intomainfrom
sdkauto/Azure.ResourceManager.AppNetwork-6060192
Mar 27, 2026
Merged

[AutoPR Azure.ResourceManager.AppNetwork]-generated-from-SDK Generation - .NET-6060192#57448
deveshdama merged 15 commits intomainfrom
sdkauto/Azure.ResourceManager.AppNetwork-6060192

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Mar 25, 2026

Configurations: 'specification/applink/AppLink.Management/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'bf394b468f3f3cf9d0c678282d7efdf9b3411132' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6060192 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=0aeba4af-c706-f111-8406-000d3a5b007c Submitted by: ddama@microsoft.com ## Release Plan Details - Release Plan: https://aka.ms/sdk-release-planner?release-plan-id=0aeba4af-c706-f111-8406-000d3a5b007c Spec pull request: Azure/azure-rest-api-specs#40886 Spec API version: 2025-08-01-preview

Customization Spec PR

C# naming convention fixes: Azure/azure-rest-api-specs#41754

@github-actions github-actions Bot added the Mgmt This issue is related to a management package. label Mar 25, 2026
Add @@clientName decorator to rename the internal selfManagedVersions property
to selfManagedVersionDetail in C#, resolving CS0102 duplicate definition error
where the flattened public property collided with the internal property name.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mgmt SDK PR Review — Azure.ResourceManager.AppNetwork

Phase 1: Versioning ✅

  • Version 1.0.0-beta.1 — no major version bump issue
  • No ApiCompatVersion (new package, first beta) — OK
  • No ApiCompatBaseline.txt — OK

Phase 2: API Review ⚠️

  • Resource/Collection/Data namingAppLinkCollection, AppLinkData, AppLinkMemberCollection, AppLinkMemberData
  • Operation body parametersAppLinkPatch, AppLinkMemberPatch for PATCH ✅
  • Issues found: 9 inline comments — primarily around contextual naming for generic types and DateTimeOffset property conventions

Phase 3: Breaking Change Detection ⏭️

Skipped — no prior stable version (ApiCompatVersion not present).


🤖 arcturus-copilot

- Renamed generic types with AppLink prefix: ProvisioningState, ClusterType,
  UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile,
  ReleaseChannelInfo, VersionInfo
- Renamed DateTimeOffset properties: StartTimestamp -> StartOn, EndTimestamp -> EndOn
- Updated tsp-location.yaml to point to spec commit with clientName decorators

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Renamed generic types with AppLink prefix: ProvisioningState, ClusterType,
  UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile,
  ReleaseChannelInfo, VersionInfo
- Renamed DateTimeOffset properties: StartTimestamp -> StartOn, EndTimestamp -> EndOn
- Updated tsp-location.yaml to point to spec commit with clientName decorators

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-Review: Azure.ResourceManager.AppNetwork PR

Phase 1 (Versioning): ✅ Pass — Version 1.0.0-beta.1, new package, no ApiCompatVersion concerns.

Phase 2 (API Review): Found 4 remaining naming issues after the previous round of fixes.

Phase 3 (Breaking Changes): ⏭️ Skipped — no prior stable version.

Summary: The previous 9 naming issues have all been resolved. This round identifies 4 additional naming concerns — 2 generic type names and 2 generic method names.


🤖 arcturus-copilot

@ArcturusZhang ArcturusZhang marked this pull request as ready for review March 26, 2026 00:56
Copilot AI review requested due to automatic review settings March 26, 2026 00:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new, generated Azure Resource Manager client library package for Microsoft.AppLink under sdk/appnetwork/Azure.ResourceManager.AppNetwork, based on the 2025-08-01-preview API version, including generated models, paging/LRO helpers, and TypeSpec generation metadata.

Changes:

  • Introduces tsp-location.yaml + metadata.json to track TypeSpec source location and API version for regeneration.
  • Adds generated REST operations, pageable/async pageable collection result types, and ARM long-running operation wrappers.
  • Adds a large set of generated models and JSON (de)serialization infrastructure, plus a minimal project/solution scaffold.

Reviewed changes

Copilot reviewed 7 out of 116 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
sdk/appnetwork/Azure.ResourceManager.AppNetwork/tsp-location.yaml TypeSpec source location for regeneration (spec repo/commit + emitter package json).
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/RestOperations/UpgradeHistoriesRestOperations.cs Generated request builders for UpgradeHistories list operations.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/RestOperations/AvailableVersionsRestOperations.cs Generated request builders for AvailableVersions list operations.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/ProviderConstants.cs Provider namespace constant helper.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/UpgradeHistoryProperties.cs Generated model for upgrade history properties.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/UpgradeHistoryListResult.cs Generated internal list-result model for upgrade histories paging.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/UpgradeHistory.cs Generated resource data model for upgrade history.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/UpgradeHistory.Serialization.cs JSON (de)serialization for UpgradeHistory.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/SelfManagedVersions.cs Generated internal model for self-managed versions.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/SelfManagedVersions.Serialization.cs JSON (de)serialization for SelfManagedVersions.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/SelfManagedUpgradeProfile.cs Generated internal model for self-managed upgrade profile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/SelfManagedUpgradeProfile.Serialization.cs JSON (de)serialization for SelfManagedUpgradeProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/PrivateConnectProfile.cs Generated internal model for private connect profile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/PrivateConnectProfile.Serialization.cs JSON (de)serialization for PrivateConnectProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/ObservabilityProfile.cs Generated internal model for observability profile + computed endpoint property.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/ObservabilityProfile.Serialization.cs JSON (de)serialization for ObservabilityProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/MetricsProfile.cs Generated internal metrics profile model.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/MetricsProfile.Serialization.cs JSON (de)serialization for MetricsProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/Metadata.cs Generated internal metadata model.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/Metadata.Serialization.cs JSON (de)serialization for Metadata.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/FullyManagedVersions.cs Generated internal model for fully-managed versions.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/FullyManagedVersions.Serialization.cs JSON (de)serialization for FullyManagedVersions.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/FullyManagedUpgradeProfile.cs Generated internal model for fully-managed upgrade profile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/FullyManagedUpgradeProfile.Serialization.cs JSON (de)serialization for FullyManagedUpgradeProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/EastWestGatewayVisibility.cs Generated “string-enum” struct for gateway visibility.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/EastWestGatewayProfile.cs Generated internal model for east-west gateway profile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/EastWestGatewayProfile.Serialization.cs JSON (de)serialization for EastWestGatewayProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AzureResourceManagerAppNetworkContext.cs Source-generation context registration for ModelReaderWriter.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AvailableVersionProperties.cs Generated model for available version properties + convenience accessors.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AvailableVersionListResult.cs Generated internal list-result model for available versions paging.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AvailableVersion.cs Generated resource data model for an available version resource.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkVersionInfo.cs Generated model for version + upgrades info.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkVersionInfo.Serialization.cs JSON (de)serialization for AppLinkVersionInfo.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkUpgradeReleaseChannel.cs Generated “string-enum” struct for upgrade release channel.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkUpgradeProfile.cs Generated model with convenience properties for upgrade profiles.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkUpgradeMode.cs Generated “string-enum” struct for upgrade mode.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkReleaseChannelInfo.cs Generated model for release channel info.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkReleaseChannelInfo.Serialization.cs JSON (de)serialization for AppLinkReleaseChannelInfo.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkProvisioningState.cs Generated “string-enum” struct for provisioning state.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkProperties.cs Generated internal model for AppLink properties.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkProperties.Serialization.cs JSON (de)serialization for AppLinkProperties.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkPatch.cs Generated patch model for AppLink updates.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkMemberUpdateProperties.cs Generated update-properties model for AppLinkMember patch.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkMemberProperties.cs Generated properties model for AppLinkMember.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkMemberPatch.cs Generated patch model for AppLinkMember updates.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkMemberListResult.cs Generated internal list-result model for AppLinkMember paging.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkListResult.cs Generated internal list-result model for AppLink paging.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkConnectivityProfile.cs Generated model with convenience properties for connectivity configuration.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkConnectivityProfile.Serialization.cs JSON (de)serialization for AppLinkConnectivityProfile.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkClusterType.cs Generated “string-enum” struct for cluster type.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/LongRunningOperation/AppNetworkArmOperationOfT.cs Generated generic ARM LRO wrapper for AppNetwork operations.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/LongRunningOperation/AppNetworkArmOperation.cs Generated non-generic ARM LRO wrapper for AppNetwork operations.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/LongRunningOperation/AppLinkOperationSource.cs Generated IOperationSource for AppLinkResource LRO result materialization.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/LongRunningOperation/AppLinkMemberOperationSource.cs Generated IOperationSource for AppLinkMemberResource LRO result materialization.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/SerializationFormat.cs Internal enum used for query serialization formatting.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/RequestContextExtensions.cs Internal helper to parse RequestContext into cancellation/error options.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/RawRequestUriBuilderExtensions.cs Internal helpers for query append/update.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/PageableWrapper.cs Internal adapter from Pageable to Pageable.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/Optional.cs Internal Optional helpers used by serialization code.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/ErrorResult.cs Internal Response wrapper that throws on Value access.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/CodeGenTypeAttribute.cs Internal codegen customization attribute.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/CodeGenSuppressAttribute.cs Internal codegen suppression attribute.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/CodeGenSerializationAttribute.cs Internal codegen serialization customization attribute.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/CodeGenMemberAttribute.cs Internal codegen member attribute.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/ClientPipelineExtensions.cs Internal pipeline send + error handling helpers.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/ChangeTrackingList.cs Internal change-tracking list for PATCH semantics.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/ChangeTrackingDictionary.cs Internal change-tracking dictionary for PATCH semantics.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/AsyncPageableWrapper.cs Internal adapter from AsyncPageable to AsyncPageable.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Internal/Argument.cs Internal argument validation helpers.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Extensions/MockableAppNetworkResourceGroupResource.cs Mockable extension wrapper for ResourceGroupResource convenience methods.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Extensions/MockableAppNetworkArmClient.cs Mockable extension wrapper for ArmClient resource getters.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/UpgradeHistoriesGetByAppLinkMemberCollectionResultOfT.cs Pageable result wrapper for UpgradeHistories list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/UpgradeHistoriesGetByAppLinkMemberAsyncCollectionResultOfT.cs AsyncPageable result wrapper for UpgradeHistories list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AvailableVersionsGetByLocationCollectionResultOfT.cs Pageable result wrapper for AvailableVersions list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AvailableVersionsGetByLocationAsyncCollectionResultOfT.cs AsyncPageable result wrapper for AvailableVersions list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AppLinksGetBySubscriptionCollectionResultOfT.cs Pageable result wrapper for AppLinks subscription list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AppLinksGetBySubscriptionAsyncCollectionResultOfT.cs AsyncPageable result wrapper for AppLinks subscription list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AppLinksGetByResourceGroupCollectionResultOfT.cs Pageable result wrapper for AppLinks RG list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AppLinksGetByResourceGroupAsyncCollectionResultOfT.cs AsyncPageable result wrapper for AppLinks RG list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AppLinkMembersGetByAppLinkCollectionResultOfT.cs Pageable result wrapper for AppLinkMembers list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/CollectionResults/AppLinkMembersGetByAppLinkAsyncCollectionResultOfT.cs AsyncPageable result wrapper for AppLinkMembers list.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/AppLinkResource.Serialization.cs IJsonModel/IPersistableModel plumbing for AppLinkResource data.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/AppLinkMemberResource.Serialization.cs IJsonModel/IPersistableModel plumbing for AppLinkMemberResource data.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/AppLinkMemberData.cs Generated tracked resource data model for AppLinkMember.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/AppLinkData.cs Generated tracked resource data model for AppLink.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Azure.ResourceManager.AppNetwork.csproj New project file for the generated package.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/metadata.json API version metadata for the RP.
sdk/appnetwork/Azure.ResourceManager.AppNetwork/Azure.ResourceManager.AppNetwork.sln Solution scaffold for the package.

Comment thread sdk/appnetwork/Azure.ResourceManager.AppNetwork/tsp-location.yaml Outdated
Comment thread sdk/appnetwork/Azure.ResourceManager.AppNetwork/tsp-location.yaml
ArcturusZhang and others added 6 commits March 26, 2026 09:18
Rename AvailableVersion -> AppLinkAvailableVersion,
UpgradeHistory -> AppLinkUpgradeHistory, and methods
GetByLocation -> GetAppLinkAvailableVersionsByLocation,
GetByAppLinkMember -> GetAppLinkUpgradeHistories.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add minimal test project with test base and environment classes.
Fix .sln to include test project and remove stale GUID entries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…thub.com:ArcturusZhang/azure-sdk-for-net into sdkauto/Azure.ResourceManager.AppNetwork-6060192

# Conflicts:
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/api/Azure.ResourceManager.AppNetwork.net10.0.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/api/Azure.ResourceManager.AppNetwork.net8.0.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/api/Azure.ResourceManager.AppNetwork.netstandard2.0.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/ArmAppNetworkModelFactory.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkAvailableVersionProperties.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkUpgradeHistoryProperties.Serialization.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AppLinkUpgradeHistoryProperties.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/src/Generated/Models/AzureResourceManagerAppNetworkContext.cs
#	sdk/appnetwork/Azure.ResourceManager.AppNetwork/tsp-location.yaml
Add Directory.Build.props, ci.mgmt.yml, assets.json, and
src/Properties/AssemblyInfo.cs to match standard mgmt SDK structure.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ArcturusZhang ArcturusZhang requested a review from jsquire as a code owner March 26, 2026 03:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.AppNetwork

Comment thread sdk/appnetwork/Azure.ResourceManager.AppNetwork/tsp-location.yaml Outdated
@deveshdama deveshdama enabled auto-merge (squash) March 26, 2026 04:26
Comment thread sdk/appnetwork/Azure.ResourceManager.AppNetwork/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@ArthurMa1978 ArthurMa1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure SDK Management PR Review — Azure.ResourceManager.AppNetwork

Phase 1: Versioning Review ✅ PASS

  • Version 1.0.0-beta.1 — no major version bump concerns (new package).
  • No ApiCompatVersion present — expected for a brand-new package.
  • No ApiCompatBaseline.txt — no suppressed breaking changes.

Phase 2: API Review — 6 issues found

# Severity Issue
1 🔴 AppLinkMemberData.Properties is public — properties should be flattened into the Data type
2 🔴 AppLinkAvailableVersion.Properties is public — properties should be flattened
3 🔴 AppLinkMemberPatch.Properties is public — properties should be flattened into the Patch type
4 🔴 AppLinkUpgradeHistory.Properties is public — properties should be flattened
5 🟡 EastWestGatewayVisibility lacks service-context prefix
6 🟡 AppLinkClusterType.AKS should use PascalCase per acronym guidelines

What passes review:

  • AppLinkData properly flattens its AppLinkProperties bag
  • ✅ Resource naming follows conventions
  • ✅ PATCH body models correctly named: AppLinkPatch, AppLinkMemberPatch
  • ✅ PUT body models correctly use Data suffix
  • ✅ DateTime properties use On suffix: StartOn, EndOn
  • ✅ Resource ID properties use ResourceIdentifier type
  • ✅ Location properties use AzureLocation type
  • ✅ Enum types are singular
  • ✅ No disallowed suffixes

Phase 3: Breaking Change Detection — SKIPPED

No ApiCompatVersion in .csproj — no prior stable version to compare against.


Total inline comments: 6

ArthurMa1978 added a commit to Azure/azure-rest-api-specs that referenced this pull request Mar 27, 2026
…ronym

Add two @@clientName decorators in client.tsp for the C# SDK:

1. EastWestGatewayVisibility -> AppLinkEastWestGatewayVisibility
   (contextual naming: add AppLink prefix for service context)

2. ClusterType.AKS -> Aks
   (PascalCase convention: 3+ letter acronyms use PascalCase)

These address remaining naming issues from the C# SDK review of
Azure/azure-sdk-for-net#57448.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ArthurMa1978 added a commit to Azure/azure-rest-api-specs that referenced this pull request Mar 27, 2026
…ronym

Add two @@clientName decorators in client.tsp for the C# SDK:

1. EastWestGatewayVisibility -> AppLinkEastWestGatewayVisibility
   (contextual naming: add AppLink prefix for service context)

2. ClusterType.AKS -> Aks
   (PascalCase convention: 3+ letter acronyms use PascalCase)

These address remaining naming issues from the C# SDK review of
Azure/azure-sdk-for-net#57448.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ArthurMa1978 and others added 4 commits March 27, 2026 15:51
- EastWestGatewayVisibility -> AppLinkEastWestGatewayVisibility
- ClusterType.AKS -> Aks

Spec PR: Azure/azure-rest-api-specs#41832

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Point to merged commit 762a9f2b1d4ae360a647e37b02f7074348643667
from Azure/azure-rest-api-specs#41832

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Updated release date for version 1.0.0-beta.1.
Updated the release date format for version 1.0.0-beta.1.
@deveshdama deveshdama merged commit 948c2e3 into main Mar 27, 2026
22 checks passed
@deveshdama deveshdama deleted the sdkauto/Azure.ResourceManager.AppNetwork-6060192 branch March 27, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants