Add C# clientName decorators for AppLink SDK naming conventions#41754
Merged
ArcturusZhang merged 4 commits intoAzure:mainfrom Mar 26, 2026
Merged
Add C# clientName decorators for AppLink SDK naming conventions#41754ArcturusZhang merged 4 commits intoAzure:mainfrom
ArcturusZhang merged 4 commits intoAzure:mainfrom
Conversation
- Add AppLink prefix to generic types: ProvisioningState, ClusterType, UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile, ReleaseChannelInfo, VersionInfo - Rename DateTimeOffset properties: startTimestamp -> startOn, endTimestamp -> endOn - Fix selfManagedVersions flattening name collision
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
deveshdama
approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds C#-specific @@clientName decorators to align the AppLink Management SDK with Azure SDK naming conventions and resolve a C# codegen collision.
Changes:
- Adds C# client name overrides to prefix key enums/models with
AppLinkto avoid cross-SDK naming collisions. - Renames
startTimestamp/endTimestamptostartOn/endOnfor C#DateTimeOffsetnaming conventions. - Fixes a C# flattening name collision by renaming
selfManagedVersionstoselfManagedVersionDetailin the C# projection.
Rename AvailableVersion -> AppLinkAvailableVersion, UpgradeHistory -> AppLinkUpgradeHistory, and their Properties companions. Rename listByLocation -> GetAppLinkAvailableVersionsByLocation, listByAppLinkMember -> GetAppLinkUpgradeHistories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ArthurMa1978
approved these changes
Mar 26, 2026
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Apr 7, 2026
…e#41754) * Add clientName for selfManagedVersions to avoid C# name collision * Add C# clientName decorators for AppLink SDK naming conventions - Add AppLink prefix to generic types: ProvisioningState, ClusterType, UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile, ReleaseChannelInfo, VersionInfo - Rename DateTimeOffset properties: startTimestamp -> startOn, endTimestamp -> endOn - Fix selfManagedVersions flattening name collision * Add clientName decorators for remaining generic types and methods Rename AvailableVersion -> AppLinkAvailableVersion, UpgradeHistory -> AppLinkUpgradeHistory, and their Properties companions. Rename listByLocation -> GetAppLinkAvailableVersionsByLocation, listByAppLinkMember -> GetAppLinkUpgradeHistories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Run tsp format on client.tsp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Apr 9, 2026
…e#41754) * Add clientName for selfManagedVersions to avoid C# name collision * Add C# clientName decorators for AppLink SDK naming conventions - Add AppLink prefix to generic types: ProvisioningState, ClusterType, UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile, ReleaseChannelInfo, VersionInfo - Rename DateTimeOffset properties: startTimestamp -> startOn, endTimestamp -> endOn - Fix selfManagedVersions flattening name collision * Add clientName decorators for remaining generic types and methods Rename AvailableVersion -> AppLinkAvailableVersion, UpgradeHistory -> AppLinkUpgradeHistory, and their Properties companions. Rename listByLocation -> GetAppLinkAvailableVersionsByLocation, listByAppLinkMember -> GetAppLinkUpgradeHistories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Run tsp format on client.tsp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ealianis
pushed a commit
that referenced
this pull request
Apr 17, 2026
* Add clientName for selfManagedVersions to avoid C# name collision * Add C# clientName decorators for AppLink SDK naming conventions - Add AppLink prefix to generic types: ProvisioningState, ClusterType, UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile, ReleaseChannelInfo, VersionInfo - Rename DateTimeOffset properties: startTimestamp -> startOn, endTimestamp -> endOn - Fix selfManagedVersions flattening name collision * Add clientName decorators for remaining generic types and methods Rename AvailableVersion -> AppLinkAvailableVersion, UpgradeHistory -> AppLinkUpgradeHistory, and their Properties companions. Rename listByLocation -> GetAppLinkAvailableVersionsByLocation, listByAppLinkMember -> GetAppLinkUpgradeHistories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Run tsp format on client.tsp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ealianis
pushed a commit
that referenced
this pull request
Apr 17, 2026
* Add clientName for selfManagedVersions to avoid C# name collision * Add C# clientName decorators for AppLink SDK naming conventions - Add AppLink prefix to generic types: ProvisioningState, ClusterType, UpgradeMode, UpgradeReleaseChannel, ConnectivityProfile, UpgradeProfile, ReleaseChannelInfo, VersionInfo - Rename DateTimeOffset properties: startTimestamp -> startOn, endTimestamp -> endOn - Fix selfManagedVersions flattening name collision * Add clientName decorators for remaining generic types and methods Rename AvailableVersion -> AppLinkAvailableVersion, UpgradeHistory -> AppLinkUpgradeHistory, and their Properties companions. Rename listByLocation -> GetAppLinkAvailableVersionsByLocation, listByAppLinkMember -> GetAppLinkUpgradeHistories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Run tsp format on client.tsp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
@@clientNamedecorators inclient.tspfor the C# SDK to follow Azure SDK naming conventions:Contextual naming (add
AppLinkprefix)ProvisioningState→AppLinkProvisioningStateClusterType→AppLinkClusterTypeUpgradeMode→AppLinkUpgradeModeUpgradeReleaseChannel→AppLinkUpgradeReleaseChannelConnectivityProfile→AppLinkConnectivityProfileUpgradeProfile→AppLinkUpgradeProfileReleaseChannelInfo→AppLinkReleaseChannelInfoVersionInfo→AppLinkVersionInfoDateTimeOffset naming convention
startTimestamp→startOnendTimestamp→endOnBug fix
selfManagedVersions→selfManagedVersionDetail(fixes C# CS0102 compilation error where the flattened property name collided with the internal property name)Motivation
These changes address naming issues identified during the C# SDK review of Azure/azure-sdk-for-net#57448. The renames only affect the C# SDK via
@@clientName(..., "csharp")and do not impact other languages.