Skip to content

Add C# clientName decorators for AppLink EastWestGatewayVisibility and AKS acronym#41832

Merged
ArcturusZhang merged 1 commit intomainfrom
applink-csharp-naming-fix-2
Mar 27, 2026
Merged

Add C# clientName decorators for AppLink EastWestGatewayVisibility and AKS acronym#41832
ArcturusZhang merged 1 commit intomainfrom
applink-csharp-naming-fix-2

Conversation

@ArthurMa1978
Copy link
Copy Markdown
Member

Changes

Add two @@clientName decorators in client.tsp for the C# SDK to follow Azure SDK naming conventions:

Contextual naming (add AppLink prefix)

  • EastWestGatewayVisibilityAppLinkEastWestGatewayVisibility
    Per the API review guidelines, all types must include sufficient context in their name. EastWestGatewayVisibility could apply to any service with east-west gateways.

PascalCase acronym convention

  • ClusterType.AKSAks
    Per the Azure SDK naming guidelines, acronyms of 3+ letters should use PascalCase (capitalize first letter only), e.g., Aes, Tcp, Http.

Motivation

These changes address remaining naming issues identified during the C# SDK review of Azure/azure-sdk-for-net#57448. This is a follow-up to #41754 which addressed the initial batch of naming fixes.

The renames only affect the C# SDK via @@clientName(..., "csharp") and do not impact other languages or the wire format.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added TypeSpec Authored with TypeSpec labels Mar 27, 2026
…ronym

Add two @@clientName decorators in client.tsp for the C# SDK:

1. EastWestGatewayVisibility -> AppLinkEastWestGatewayVisibility
   (contextual naming: add AppLink prefix for service context)

2. ClusterType.AKS -> Aks
   (PascalCase convention: 3+ letter acronyms use PascalCase)

These address remaining naming issues from the C# SDK review of
Azure/azure-sdk-for-net#57448.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ArthurMa1978 ArthurMa1978 force-pushed the applink-csharp-naming-fix-2 branch from f96bd9c to 8b7b9f4 Compare March 27, 2026 07:22
ArthurMa1978 added a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 27, 2026
- EastWestGatewayVisibility -> AppLinkEastWestGatewayVisibility
- ClusterType.AKS -> Aks

Spec PR: Azure/azure-rest-api-specs#41832

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ArcturusZhang ArcturusZhang merged commit 762a9f2 into main Mar 27, 2026
40 checks passed
@ArcturusZhang ArcturusZhang deleted the applink-csharp-naming-fix-2 branch March 27, 2026 08:06
ArthurMa1978 added a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 27, 2026
Point to merged commit 762a9f2b1d4ae360a647e37b02f7074348643667
from Azure/azure-rest-api-specs#41832

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Apr 7, 2026
…d AKS acronym (Azure#41832)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Apr 9, 2026
…d AKS acronym (Azure#41832)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ealianis pushed a commit that referenced this pull request Apr 17, 2026
…d AKS acronym (#41832)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ealianis pushed a commit that referenced this pull request Apr 17, 2026
…d AKS acronym (#41832)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants