New SDK for 2018-06-30 changes and other nit fixes ver2#4971
Merged
dsgouda merged 7 commits intoAzure:psSdkJson6from Oct 30, 2018
D1v38om83r:bhbrahma/newPR
Merged
New SDK for 2018-06-30 changes and other nit fixes ver2#4971dsgouda merged 7 commits intoAzure:psSdkJson6from D1v38om83r:bhbrahma/newPR
dsgouda merged 7 commits intoAzure:psSdkJson6from
D1v38om83r:bhbrahma/newPR
Conversation
Contributor
Author
9 tasks
dsgouda
suggested changes
Oct 30, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
All good, just needs a couple of quick fixes
|
|
||
| [assembly: AssemblyVersion("3.0.1.0")] | ||
| [assembly: AssemblyFileVersion("3.3.0.0")] | ||
| [assembly: AssemblyFileVersion("3.8.0-preview")] |
Contributor
There was a problem hiding this comment.
Please rename this to 3.8.0.0 (-preview is not allowed in file versioning)
| <Version>3.4.0-preview</Version> | ||
| <Version>3.8.0-preview</Version> | ||
| <!-- Remove the Preview description in PackageReleaseNotes once the preview is removed.--> | ||
| <AssemblyTitle>Microsoft Azure Automation Management Library</AssemblyTitle> |
Contributor
There was a problem hiding this comment.
Still missing PackageReleaseNotes
Contributor
Author
There was a problem hiding this comment.
Added package release notes.
Contributor
Author
|
@dsgouda |
Contributor
|
Yes this is expected |
Contributor
|
@D1v38om83r appreciate your patience. |
ahamad-MS
pushed a commit
to ahamad-MS/azure-sdk-for-net
that referenced
this pull request
Oct 31, 2018
* Generated SDK using generate.ps1 * Added changes to RP.Props * Added SDK for Automation.Python2Packages and re-recorded tests * Reduced poll interval for modules and python2packages for faster playback * new test python2 packages, DynamicGroup and Prepost * Changed version for assembyinfo and csproj files * Addressed PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python2Packages for azure automation. Added new API specs, re-recorded tests for Automation scenarios. Added a new test for Python2Package scenarios.
API PR: Created specs for python 2 packages azure-rest-api-specs#3713
Dynamic Group support change
API PR : Swagger change for Update configuration dynamic group azure-rest-api-specs#4165
Pre- post support change
API PR : Swagger change for pre and post script azure-rest-api-specs#4298
Following on from #4916
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.