Created specs for python 2 packages by D1v38om83r · Pull Request #3713 · Azure/azure-rest-api-specs

D1v38om83r · 2018-08-23T21:15:11Z

Swagger spec update for new feature. Python 2 package support in Azure Automation.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-08-23T21:16:15Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3125

D1v38om83r · 2018-08-23T21:17:05Z

@ravbhatnagar can you please review on behalf of the ARM team. I am introducing a new resource here that is practically the same as Azure automation Module (powershell), but for python.

AutorestCI · 2018-08-23T21:18:02Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-23T21:18:20Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2018-08-23T21:20:09Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-23T21:22:02Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3414

AutorestCI · 2018-08-23T21:22:18Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2842

D1v38om83r · 2018-08-27T23:54:03Z

ping!
@ravbhatnagar can you please review on behalf of the ARM team. I am introducing a new resource here that is practically the same as Azure automation Module (powershell), but for python.

ravbhatnagar · 2018-08-30T15:02:48Z

...ation/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/python2package.json

+    },
+    "ModuleProperties": {
+      "properties": {
+        "isGlobal": {


bools are typically not recommended as they are less descriptive and dont allow for future expansion of states if needed.

The property isGlobal is set in out data model as a boolean everywhere. Its not expected to change ever. The specs for Python 2 packages are practically the same a Powershell modules for consistency, except for paths.

ravbhatnagar · 2018-08-30T15:03:11Z

...ation/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/python2package.json

+          "type": "string",
+          "description": "Gets or sets the description."
+        },
+        "isComposite": {


same comment for bool

isComposite is never expected to change. The specs for Python 2 packages are practically the same a Powershell modules for consistency, except for paths.

ravbhatnagar · 2018-08-30T15:04:10Z

...ation/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/python2package.json

+          "x-ms-client-flatten": true,
+          "description": "Gets or sets the module update properties."
+        },
+        "name": {


Is name of the resource really updatable?

no, only the tag is updatable. Left in there for consistency with PowerShell modules.

Consistency at the expense of something which doesnt work is not recommended. Please fix.

I have removed the parameters which have no effect.

ravbhatnagar · 2018-08-30T15:04:30Z

...ation/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/python2package.json

+          "type": "string",
+          "description": "Gets or sets name of the resource."
+        },
+        "location": {


location of azure resources is not updatbale.

yes, that is correct. Left in there for consistency with PowerShell modules.

same comment as above. lets fix this. And even fix powershell in a new api-version.

I have removed the parameters which have no effect.

ravbhatnagar · 2018-08-30T15:05:50Z

...ation/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/python2package.json

+          "x-ms-client-flatten": true,
+          "description": "Gets or sets the module create properties."
+        },
+        "name": {


name comes from the URL. It should be readonly in the request body

Parameter name has been dropped

ravbhatnagar · 2018-08-30T15:06:25Z

...ation/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/python2package.json

+      ],
+      "description": "The parameters supplied to the create or update module properties."
+    },
+    "ModuleCreateOrUpdateParameters": {


why is the same model no used for request and response? It helps in GET-PUT pipeline and makes it simpler to consume

jhendrixMSFT · 2018-08-31T19:58:58Z

Please be sure to review the fixes made to the powershell equivalent as there were some bugs in that swagger which made the "GetContent" API not work, see the history.

jhendrixMSFT · 2018-09-12T20:28:59Z

@D1v38om83r any update on ARM feedback?

…t-api-specs into bhbrahma-pr

jhendrixMSFT · 2018-09-14T20:50:43Z

@D1v38om83r there is a merge conflict, can you please rebase your changes on top of master?

jhendrixMSFT · 2018-09-19T15:09:19Z

@D1v38om83r ping

…into bhbrahma-pr

AutorestCI · 2018-09-20T22:51:01Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

D1v38om83r · 2018-09-20T22:52:54Z

@jhendrixMSFT the merge conflicts have been resolved

jhendrixMSFT · 2018-09-20T22:54:33Z

@D1v38om83r thanks! Where are we with the ARM review?

jhendrixMSFT · 2018-09-20T23:01:15Z

@D1v38om83r also has this service been deployed?

D1v38om83r · 2018-09-24T21:20:08Z

@ravbhatnagar can you please take a look at the changes I made addressing your PR comments.
@jhendrixMSFT yes the service has been deployed

jhendrixMSFT · 2018-09-26T17:10:00Z

Looking at the ARM feedback I think the only remaining issue is why is the same model not used for request and response. Can this be fixed?

D1v38om83r · 2018-09-27T20:37:20Z

The request and response are too dissimilar, there is next to no overlap. It doesn't make sense to combine them.

jhendrixMSFT · 2018-09-27T20:39:45Z

Thanks for the explanation this makes sense. Will merge EOD unless @ravbhatnagar has any objections.

D1v38om83r and others added 2 commits July 26, 2018 19:43

Created specs for python 2 packages

ad7bf38

add new package to Go SDK build

1a11c87

AutorestCI mentioned this pull request Aug 23, 2018

[AutoPR automation/resource-manager] Created specs for python 2 packages Azure/azure-sdk-for-python#3192

Closed

azuresdkci assigned jhendrixMSFT Aug 23, 2018

azuresdkci requested a review from jhendrixMSFT August 23, 2018 21:16

AutorestCI mentioned this pull request Aug 23, 2018

[AutoPR automation/resource-manager] Created specs for python 2 packages Azure/azure-sdk-for-node#3414

Closed

AutorestCI mentioned this pull request Aug 23, 2018

[AutoPR automation/resource-manager] Created specs for python 2 packages Azure/azure-sdk-for-go#2531

Closed

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2018

jhendrixMSFT requested a review from ravbhatnagar August 27, 2018 15:09

ravbhatnagar reviewed Aug 30, 2018

View reviewed changes

jhendrixMSFT added the Reassign label Aug 31, 2018

azuresdkci assigned annatisch and unassigned jhendrixMSFT Aug 31, 2018

azuresdkci requested a review from annatisch August 31, 2018 22:34

ravbhatnagar added the ARMReviewInProgress label Sep 7, 2018

jhendrixMSFT removed the Reassign label Sep 10, 2018

jhendrixMSFT assigned jhendrixMSFT and unassigned annatisch Sep 12, 2018

jhendrixMSFT removed the request for review from annatisch September 12, 2018 19:10

Addressed PR comments 01

96fe005

Merge branch 'bhbrahma-pr' of https://github.com/D1v38om83r/azure-res…

acb9f2c

…t-api-specs into bhbrahma-pr

AutorestCI mentioned this pull request Sep 14, 2018

[AutoPR automation/resource-manager] Created specs for python 2 packages Azure/azure-sdk-for-go#2693

Closed

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

f3a0667

…into bhbrahma-pr

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR automation/resource-manager] Created specs for python 2 packages Azure/azure-sdk-for-go#2788

Merged

jhendrixMSFT approved these changes Sep 27, 2018

View reviewed changes

jhendrixMSFT merged commit 4f644c6 into Azure:master Sep 27, 2018

jemex mentioned this pull request Oct 23, 2018

[Automation] New SDK for 2018-06-30 changes and other nit fixes Azure/azure-sdk-for-net#4916

Closed

9 tasks

D1v38om83r mentioned this pull request Oct 30, 2018

New SDK for 2018-06-30 changes and other nit fixes ver2 Azure/azure-sdk-for-net#4971

Merged

9 tasks

Conversation

D1v38om83r commented Aug 23, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

D1v38om83r commented Aug 23, 2018

Uh oh!

AutorestCI commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented Aug 23, 2018

Uh oh!

AutorestCI commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

D1v38om83r commented Aug 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Aug 31, 2018

Uh oh!

jhendrixMSFT commented Sep 12, 2018

Uh oh!

jhendrixMSFT commented Sep 14, 2018

Uh oh!

jhendrixMSFT commented Sep 19, 2018

Uh oh!

AutorestCI commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

D1v38om83r commented Sep 20, 2018

Uh oh!

jhendrixMSFT commented Sep 20, 2018

Uh oh!

jhendrixMSFT commented Sep 20, 2018

Uh oh!

D1v38om83r commented Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

AutorestCI commented Aug 23, 2018 •

edited

Loading

AutorestCI commented Aug 23, 2018 •

edited

Loading

AutorestCI commented Aug 23, 2018 •

edited

Loading

AutorestCI commented Aug 23, 2018 •

edited

Loading

AutorestCI commented Aug 23, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

D1v38om83r commented Sep 24, 2018 •

edited

Loading